Notes
(0024195) Marcel Loose (developer) 2010-12-16 03:41	I briefly looked at your code. I have a few remarks. I would prefer a separate macro. That way it's guaranteed not to break anything. For example, your code does not support 'svnversion WC_PATH TRAIL_URL', because the second argument to Subversion_WC_INFO is the prefix to use for the variable names returned by that macro. Furthermore, I think that people who are only interested in the WC version info wouldn't want to use the full-blown Subversion_WC_INFO, because it gives way to much information. OTOH, people who want the complete WC information do not get any extra from 'svnversion'. What about a new macro Subversion_WC_BRIEF_INFO or Subversion_WC_VERSION?

(0024196) Gerald Hofmann (reporter) 2010-12-16 04:29	Regarding your first remark, yes, I agree, my code does not support the optional trail url. In this case I think this is dispensable. Can't figure out a scenario where such complex call could be useful for a macro that simply returns info of a particular wc and is not used to actually maintain the wc. _WC_COMPACT_VERSION does give additional information over "svn imfo". Most important (for me) is the trailing "M" if the wc was modified, or a mixed revision string. ASFAIK, I can't get this from "svn info". My intention is to use this information to e.g. set a prepro define and brand an executable to be built from not yet commited sources. Subversion_WC_INFO was not added by me, it's already available in 2.8. Can't see any reason to relocate it to a separate macro.

(0024199) Marcel Loose (developer) 2010-12-16 07:49	I didn't mean to say that Subversion_WC_INFO should be relocated. It was already in FindSubversion before I took over maintenance of this module. I meant to say that I think that your piece of code should not become part of Subversion_WC_INFO, but should become part of a new macro, e.g., Subversion_WC_BRIEF_INFO or Subversion_WC_VERSION. You do have a point w.r.t. information about changed sources in your working copy. You'd need 'svn status' for that, because 'svn info' doesn't give you that information. IMHO yet another reason for adding a new macro which only calls 'svnversion' and nothing more.

(0024200) Gerald Hofmann (reporter) 2010-12-16 08:02	Yep, just a little misunderstanding regarding Subversion_WC_INFO. No objection to your proposal of a new macro. I agree, separating this will keep the subversion module easier to maintain. Thank you!

(0036656) daum (reporter) 2014-08-21 10:26	I do not know if you are aware of this, but actually "svn info <wc>" does NOT give you an overall revision for the whole working directory as "svnversion" does, but only for the directory node. Please refer to the svninfo.txt I have uploaded for an example. Subversion_WC_REVISION is therefore very misleading as it does NOT necessarily give the revision of the working copy.

(0036657) Marcel Loose (developer) 2014-08-21 11:02	Yes, I am aware of that. This basically is a Subversion issue. Subversion_WC_REVISION simply contains the revision number that "svn info" returns as "Revision:". I agree that this can be misleading, but you should complain to the Subversion developers.

(0036671) daum (reporter) 2014-08-25 05:08	I once did that for a similar/related svn behavior. The answer pretty much boils down to "intended behavior". Which is also the reason why the svnversion tool exists in the first place. I only wanted to add to the current discussion that, if you intend to tag your generated package/library/whatever with an svn revision through CMake (which we do), the output of "svn info" can be "hazardous" and svnversion is by far the better way to go.

(0041633) Kitware Robot (administrator) 2016-06-10 14:27	Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.

Issue History
Date Modified	Username	Field	Change
2009-12-11 10:05	Gerald Hofmann	New Issue
2009-12-11 10:05	Gerald Hofmann	File Added: FindSubversion.cmake
2010-12-14 17:02	David Cole	Assigned To	=> Marcel Loose
2010-12-14 17:02	David Cole	Status	new => assigned
2010-12-16 03:41	Marcel Loose	Note Added: 0024195
2010-12-16 04:29	Gerald Hofmann	Note Added: 0024196
2010-12-16 07:49	Marcel Loose	Note Added: 0024199
2010-12-16 08:02	Gerald Hofmann	Note Added: 0024200
2011-06-24 14:53	Aaron C. Meadows	Tag Attached: FindSubversion
2012-08-28 06:05	Marcel Loose	Status	assigned => backlog
2014-08-21 10:22	daum	File Added: svninfo.txt
2014-08-21 10:26	daum	Note Added: 0036656
2014-08-21 11:02	Marcel Loose	Note Added: 0036657
2014-08-25 05:08	daum	Note Added: 0036671
2016-06-10 14:27	Kitware Robot	Note Added: 0041633
2016-06-10 14:27	Kitware Robot	Status	backlog => resolved
2016-06-10 14:27	Kitware Robot	Resolution	open => moved
2016-06-10 14:31	Kitware Robot	Status	resolved => closed

Relationships