View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0010473

CMake

public

2010-03-27 13:53

2016-06-10 14:31

Reporter

rubenvb

Assigned To

Bill Hoffman

Priority

normal

Severity

tweak

Reproducibility

always

Status

closed

Resolution

moved

Platform

OS Version

Product Version

CMake-2-8

Target Version

Fixed in Version

Summary

0010473: Default generator on Windows

Description

It would be handy for CMake not to default to the highest MSVC installed when run on Windows. Better would be:
a) check CMAKE_GENERATOR environment variable for which one to use. This should be quite easy and can still default to the newest MSVC version, but this should be checked first.
b) find available compilers at runtime (ie when running CMake) and let the user select the one he wants from a list. This would be a performance hit and not preferred

This would allow those few people using either more than one compiler or mingw(-w64/w32) to just run "cmake .." and (g/mingw32-)make without the need for -G"MinGW Makefiles". It shouldn't be too hard to implement and would simplify working with CMake a lot.

Tags

patch

Attached Files

cmake_default_generator.patch [^] (709 bytes) 2012-06-16 10:31 [Show Content] [Hide Content]

diff -ru Source/cmake.cxx Source_new//cmake.cxx
--- Source/cmake.cxx	2012-04-18 14:10:54.000000000 -0400
+++ Source_new//cmake.cxx	2012-06-15 16:41:30.644383790 -0400
@@ -2172,7 +2172,15 @@
       cmSystemTools::SetForceUnixPaths
         (this->GlobalGenerator->GetForceUnixPaths());
       }
-    else
+    else if (getenv("CMAKE_DEFAULT_GENERATOR"))
+      {
+      const char* genName = getenv("CMAKE_DEFAULT_GENERATOR");
+      if (*genName)
+        {
+        this->SetGlobalGenerator(this->CreateGlobalGenerator(genName));
+        }
+      }
+    if(!this->GlobalGenerator)
       {
 #if defined(__BORLANDC__) && defined(_WIN32)
       this->SetGlobalGenerator(new cmGlobalBorlandMakefileGenerator);

cmake_default_generator_new.patch [^] (656 bytes) 2012-06-29 13:23 [Show Content] [Hide Content]

diff -ru Source_old/cmake.cxx Source/cmake.cxx
--- Source_old/cmake.cxx	2012-04-18 14:10:54 -0400
+++ Source/cmake.cxx	2012-06-29 13:19:44 -0400
@@ -2174,6 +2174,14 @@
       }
     else
       {
+        const char* genName = cmSystemTools::GetEnv("CMAKE_DEFAULT_GENERATOR");
+        if (genName && *genName)
+          {
+          this->SetGlobalGenerator(this->CreateGlobalGenerator(genName));
+          }
+      }
+    if(!this->GlobalGenerator)
+      {
 #if defined(__BORLANDC__) && defined(_WIN32)
       this->SetGlobalGenerator(new cmGlobalBorlandMakefileGenerator);
 #elif defined(_WIN32) && !defined(__CYGWIN__) && !defined(CMAKE_BOOT_MINGW)

Relationships

Notes
(0024485) Bill Hoffman (manager) 2011-01-06 16:30	A patch would be welcome for this.

(0029709) criptych (reporter) 2012-06-16 10:35	The attached patch modifies cmake::ActualConfigure so that when configuring a new project it will check the environment variable CMAKE_DEFAULT_GENERATOR before trying platform-specific generators.

(0029862) criptych (reporter) 2012-06-28 18:09	I realize there are more pressing concerns, but is it possible to get some kind of an acknowledgement even if the patch as-is can't be merged yet?

(0029863) Bill Hoffman (manager) 2012-06-29 09:33	It should use the getenv wrapper in cmSystemTools: static const char* GetEnv(const char* key); cmSystemTools::GetEnv("CMAKE_DEFAULT_GENERATOR")

(0029865) criptych (reporter) 2012-06-29 13:28	Thanks for your response. I didn't mean to sound impatient, it's just that this is a feature I'd been interested in myself, and it seemed like a simple fix. :) I've attached a patch which uses the new name, and cleaned up the code a bit.

(0036582) criptych (reporter) 2014-08-08 10:11	Has there been any further consideration on this?

(0041673) Kitware Robot (administrator) 2016-06-10 14:27	Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.

Issue History
Date Modified	Username	Field	Change
2010-03-27 13:53	rubenvb	New Issue
2011-01-06 16:30	Bill Hoffman	Note Added: 0024485
2011-01-06 16:30	Bill Hoffman	Assigned To	=> Bill Hoffman
2011-01-06 16:30	Bill Hoffman	Status	new => assigned
2012-06-16 10:31	criptych	File Added: cmake_default_generator.patch
2012-06-16 10:35	criptych	Note Added: 0029709
2012-06-16 12:34	criptych	Tag Attached: patch
2012-06-28 18:09	criptych	Note Added: 0029862
2012-06-29 09:33	Bill Hoffman	Note Added: 0029863
2012-06-29 13:23	criptych	File Added: cmake_default_generator_new.patch
2012-06-29 13:28	criptych	Note Added: 0029865
2014-08-08 10:11	criptych	Note Added: 0036582
2016-06-10 14:27	Kitware Robot	Note Added: 0041673
2016-06-10 14:27	Kitware Robot	Status	assigned => resolved
2016-06-10 14:27	Kitware Robot	Resolution	open => moved
2016-06-10 14:31	Kitware Robot	Status	resolved => closed