| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0010518 | CMake | CPack | public | 2010-04-08 05:50 | 2011-01-12 07:26 | ||||
| Reporter | Guillaume Duhamel | ||||||||
| Assigned To | Eric NOULARD | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | closed | Resolution | fixed | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | CMake-2-8 | ||||||||
| Target Version | CMake 2.8.4 | Fixed in Version | CMake 2.8.4 | ||||||
| Summary | 0010518: Parameter substitution not turned off for license in STGZ packages | ||||||||
| Description | In STGZ packages, parameter substitution is not turned off when displaying the license file. This may end up in a crash when running the generated .sh file as the license file may contain special characters like $ or ` (for instance, the GPL license file contains multiple `). | ||||||||
| Additional Information | I attached a (quite simple) patch to the problem. | ||||||||
| Tags | No tags attached. | ||||||||
| Attached Files |  cpack-here-doc.patch [^] (416 bytes) 2010-04-08 05:50 [Show Content]
| ||||||||
| Relationships | ||||||
|
||||||
| Relationships |
| Notes | |
|
(0023998) David Cole (manager) 2010-12-14 18:26 |
Eric, Does the attached patch look reasonable to you? Have you tried it? If you don't want it assigned to you, feel free to assign it back to me... Thanks, David |
|
(0024119) Eric NOULARD (developer) 2010-12-14 18:55 |
Hi Dave, Yes it does. I did some rough test and it works as expected. I'm not currently on my dev box, I may do some more tests and push it to next when I'm done. |
|
(0024123) Eric NOULARD (developer) 2010-12-14 19:01 |
OK I confirm the quoting of the so-called "here document" is the usual way to go, cf: http://en.wikipedia.org/wiki/Here_document#Unix_Shells [^] I'll push it when I get my hand on my dev host again. Feel free to push it yourself before me and close the bug. |
|
(0024188) Eric NOULARD (developer) 2010-12-15 15:29 |
Merge topic 'CPackSTGZ-NoSubstitution' into next 07bd856 CPackSTGZ quote here-doc, fix bug10518 Pushing upstream next To git@cmake.org:cmake.git |
| Notes |
| Issue History | |||
| Date Modified | Username | Field | Change |
| 2010-04-08 05:50 | Guillaume Duhamel | New Issue | |
| 2010-04-08 05:50 | Guillaume Duhamel | File Added: cpack-here-doc.patch | |
| 2010-12-14 18:26 | David Cole | Assigned To | => Eric NOULARD |
| 2010-12-14 18:26 | David Cole | Status | new => assigned |
| 2010-12-14 18:26 | David Cole | Note Added: 0023998 | |
| 2010-12-14 18:55 | Eric NOULARD | Note Added: 0024119 | |
| 2010-12-14 19:01 | Eric NOULARD | Note Added: 0024123 | |
| 2010-12-15 15:29 | Eric NOULARD | Note Added: 0024188 | |
| 2010-12-15 15:29 | Eric NOULARD | Status | assigned => closed |
| 2010-12-15 15:29 | Eric NOULARD | Resolution | open => fixed |
| 2010-12-15 15:29 | Eric NOULARD | Fixed in Version | => CMake 2.8.4 |
| 2011-01-12 07:26 | David Cole | Target Version | => CMake 2.8.4 |
| 2011-02-02 16:51 | Eric NOULARD | Relationship added | related to 0011788 |
| 2011-02-03 02:13 | Eric NOULARD | Relationship deleted | related to 0011788 |
| 2011-02-03 02:14 | Eric NOULARD | Relationship added | has duplicate 0011788 |
| Issue History |
| Copyright © 2000 - 2018 MantisBT Team |