View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0011491CDash(No Category)public2010-11-22 03:082010-11-22 10:25
ReporterMichal Cihar 
Assigned ToZach Mullen 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0011491: Double fclose in asynchronous submission
DescriptionOn asynchronous submission, I get following warning:

PHP Warning: fclose(): 67 is not a valid stream resource in /srv/https/cdash.cihar.com/cdash/processsubmissions.php on line 387

The problem is that do_submit which is called just before this line closes the file as well, so this line can be safely removed.
TagsNo tags attached.
Attached Files

 Relationships

  Notes
(0023480)
David Cole (manager)
2010-11-22 09:46

 I disagree.

Whoever calls fopen should also call fclose.

Do not remove the call in processsubmissions.php. Remove the one in do_submit, and make sure all callers of do_submit are doing fopen/fclose as appropriate.

do_submit should not be calling fclose: what if it is handed a file stream that is not meant to be fclose-d...?
(0023481)
Zach Mullen (developer)
2010-11-22 10:25

 Implemented the fix as Dave suggested.

Rev. 2794

 Issue History
Date Modified Username Field Change
2010-11-22 03:08 Michal Cihar New Issue
2010-11-22 03:11 Julien Jomier Assigned To => Zach Mullen
2010-11-22 03:11 Julien Jomier Status new => assigned
2010-11-22 09:46 David Cole Note Added: 0023480
2010-11-22 10:25 Zach Mullen Note Added: 0023481
2010-11-22 10:25 Zach Mullen Status assigned => resolved
2010-11-22 10:25 Zach Mullen Resolution open => fixed

Copyright © 2000 - 2018 MantisBT Team