View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0007839CMakeCMakepublic2008-10-21 17:142016-06-10 14:30
ReporterJames Bigler 
Assigned ToBill Hoffman 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionmoved 
PlatformOSOS Version
Product VersionCMake-2-6 
Target VersionFixed in Version 
Summary0007839: Fix for Bug 4524 needs a patch.
DescriptionIn Bug 0004524 I made a correction to the patch. My correction was wrong, and the code doesn't work. The SccProvider string was added twice, and the "if" logic to set the variables when only all three were specified didn't work.

I've attached a patch to the source that seems to work for me.
TagsNo tags attached.
Attached Filestxt file icon cmLocalVisualStudio7Generator.cxx.patch.txt [^] (973 bytes) 2008-10-21 17:14 [Show Content]

 Relationships

  Notes
(0013940)
Bill Hoffman (manager)
2008-10-27 13:51

$ cvs commit -m "BUG: fix for 7839 and 4524 " cmLocalVisualStudio7Generator.cxx
Committer: Bill Hoffman <bill.hoffman@kitware.com>
/cvsroot/CMake/CMake/Source/cmLocalVisualStudio7Generator.cxx,v <-- cmLocalVisualStudio7Generator.cxx
new revision: 1.233; previous revision: 1.232
(0013941)
Bill Hoffman (manager)
2008-10-27 13:53

Wait one minute....


With this patch, this stuff will be put into all projects even if users do not set the variables.

  if (!vsProjectname)
    {
    vsProjectname = "";
    }
It always has a value, so:
  if(vsProvider && vsLocalpath && vsProjectname)
will always be true.
(0013947)
Bill Hoffman (manager)
2008-10-27 15:31

Can you try this:
$ cvs commit -m "ENH: make the scc optional " cmLocalVisualStudio7Generator.cxx
Committer: Bill Hoffman <bill.hoffman@kitware.com>
/cvsroot/CMake/CMake/Source/cmLocalVisualStudio7Generator.cxx,v <-- cmLocalVisualStudio7Generator.cxx
new revision: 1.234; previous revision: 1.233
(0013948)
James Bigler (developer)
2008-10-27 15:33

Then you should probably set vsProvider, vsLocalpath and vsProjectname to 0 instead of "". They can't be used unless all three have a valid value. In a previous version of the file, I believe vsProvider and vsLocalpath were always printed out.

Also, the projects behave normally with the blank attributes:

    SccProjectName=""
    SccLocalPath=""
    SccProvider=""
(0014061)
James Bigler (developer)
2008-11-07 12:08

I applied the changes to my 2.6.2 branch (basically 2.6.2 with the changes needed for this feature), and all seems to work fine.

Thanks very much.
(0017507)
Bill Hoffman (manager)
2009-09-14 21:05

Can I close this?
(0041457)
Kitware Robot (administrator)
2016-06-10 14:27

Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.

 Issue History
Date Modified Username Field Change
2008-10-21 17:14 James Bigler New Issue
2008-10-21 17:14 James Bigler File Added: cmLocalVisualStudio7Generator.cxx.patch.txt
2008-10-27 13:51 Bill Hoffman Note Added: 0013940
2008-10-27 13:51 Bill Hoffman Status new => closed
2008-10-27 13:51 Bill Hoffman Resolution open => fixed
2008-10-27 13:53 Bill Hoffman Note Added: 0013941
2008-10-27 13:53 Bill Hoffman Status closed => new
2008-10-27 15:31 Bill Hoffman Note Added: 0013947
2008-10-27 15:31 Bill Hoffman Status new => assigned
2008-10-27 15:31 Bill Hoffman Assigned To => Bill Hoffman
2008-10-27 15:33 James Bigler Note Added: 0013948
2008-11-07 12:08 James Bigler Note Added: 0014061
2009-09-14 21:05 Bill Hoffman Note Added: 0017507
2016-06-10 14:27 Kitware Robot Note Added: 0041457
2016-06-10 14:27 Kitware Robot Status assigned => resolved
2016-06-10 14:27 Kitware Robot Resolution fixed => moved
2016-06-10 14:30 Kitware Robot Status resolved => closed


Copyright © 2000 - 2018 MantisBT Team