View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0008347ITKpublic2009-01-05 22:552009-04-29 20:02
ReporterHans Johnson 
Assigned ToMichelKitware 
PrioritylowSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionITK-3-10 
Target VersionFixed in Version 
Summary0008347: VersorRigidTransform needs SetRotationMatrix made public
DescriptionAll of the Rigid3DTransforms should be convetable to each other through the
SetCenter
SetTranslation
SetRotationMatrix

Member functions. Currently the Versor3DRigidTransform has SetRotationMatrix set as private, and thus requires code like the following to work around this (and makes it different from other Rigd 3D transform types).

=================================
EulerAnglesRigidTransformType::Pointer ZeroCenteredTransform
VersorRigid3DTransformType::Pointer VersorZeroCenteredTransform

itk::Versor<double> versorRotation;
versorRotation.Set(ZeroCenteredTransform->GetRotationMatrix());
VersorZeroCenteredTransform->SetRotation(versorRotation);
=================================

Additional InformationThe SetRotationMatrix member function should be made public.
The matrix should be checked for othoganality (exception thown if not orthog)

Then delegate to SetRotation as
itk::Versor<double> versorRotation;
versorRotation.Set(ZeroCenteredTransform->GetRotationMatrix());
VersorZeroCenteredTransform->SetRotation(versorRotation);
TagsNo tags attached.
Resolution Date
Sprint
Sprint Status
Attached Files

 Relationships
has duplicate 0006448closedHans Johnson inconsistent transform API 

  Notes
(0016010)
MichelKitware (developer)
2009-04-13 19:59

 --- itkVersorRigid3DTransform.h 2006/08/09 04:35:32 1.27
+++ itkVersorRigid3DTransform.h 2009/04/13 23:41:53 1.28
@@ -3,8 +3,8 @@
   Program: Insight Segmentation & Registration Toolkit
   Module: $RCSfile: itkVersorRigid3DTransform.h,v $
   Language: C++
- Date: $Date: 2006/08/09 04:35:32 $
- Version: $Revision: 1.27 $
+ Date: $Date: 2009/04/13 23:41:53 $
+ Version: $Revision: 1.28 $
 
   Copyright (c) Insight Software Consortium. All rights reserved.
   See ITKCopyright.txt or http://www.itk.org/HTML/Copyright.htm [^] for details.
@@ -114,10 +114,6 @@
 
   void PrintSelf(std::ostream &os, Indent indent) const;
 
- /** This method must be made protected here because it is not a safe way of
- * initializing the Versor */
- virtual void SetRotationMatrix(const MatrixType & matrix)
- { this->Superclass::SetRotationMatrix( matrix ); }
  
 private:
   VersorRigid3DTransform(const Self&); //purposely not implemented
(0016014)
Luis Ibanez (manager)
2009-04-14 10:21

 CVS diff:

http://www.itk.org/cgi-bin/viewcvs.cgi/Code/Common/itkVersorRigid3DTransform.h?root=Insight&r1=1.27&r2=1.28 [^]
(0016258)
Hans Johnson (developer)
2009-04-29 20:02

 Thanks for addressing this issue.

 Issue History
Date Modified Username Field Change
2009-01-05 22:55 Hans Johnson New Issue
2009-04-13 12:53 MichelKitware Status new => assigned
2009-04-13 12:53 MichelKitware Assigned To => MichelKitware
2009-04-13 19:51 MichelKitware Note Added: 0016007
2009-04-13 19:53 MichelKitware Note Deleted: 0016007
2009-04-13 19:55 MichelKitware Note Added: 0016008
2009-04-13 19:57 MichelKitware Note Added: 0016009
2009-04-13 19:58 MichelKitware Note Deleted: 0016008
2009-04-13 19:59 MichelKitware Note Added: 0016010
2009-04-13 19:59 MichelKitware Status assigned => resolved
2009-04-13 19:59 MichelKitware Resolution open => fixed
2009-04-14 10:21 Luis Ibanez Note Added: 0016014
2009-04-14 10:21 Luis Ibanez Note Deleted: 0016009
2009-04-29 20:02 Hans Johnson Note Added: 0016258
2009-04-29 20:02 Hans Johnson Status resolved => closed
2010-10-21 11:41 Hans Johnson Relationship added has duplicate 0006448

Copyright © 2000 - 2018 MantisBT Team