| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0009513 | CMake | Modules | public | 2009-09-09 13:48 | 2016-06-10 14:30 | ||||
| Reporter | dataangel | ||||||||
| Assigned To | Bill Hoffman | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | closed | Resolution | moved | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | CMake-2-6 | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0009513: CHECK_CXX_SOURCE_RUNS and its ilk should take files, not text | ||||||||
| Description | Putting configure checks directly into your CMakeLists.txt is bad style, just like putting it directly into your configure.ac when using autotools is bad style. If you ever switch build environments you have to go through ugly code copy and pasting between the old environment configure file and the new one. Configure checks should be in their own source files, and this good habit is what CHECK_CXX_SOURCE_RUNS and friends should do by default. At the very least file based equivalents should be provided -- having to write out file(READ ... ) commands is lame and overly verbose. | ||||||||
| Tags | No tags attached. | ||||||||
| Attached Files | |||||||||
| Relationships | |
| Relationships |
| Notes | |
|
(0017384) Bill Hoffman (manager) 2009-09-11 17:18 |
try_compile can be used like this. In fact that was the only way to do it, until someone else complained that it should be done this way... |
|
(0041592) Kitware Robot (administrator) 2016-06-10 14:27 |
Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page. |
| Notes |
| Issue History | |||
| Date Modified | Username | Field | Change |
| 2009-09-09 13:48 | dataangel | New Issue | |
| 2009-09-11 17:18 | Bill Hoffman | Note Added: 0017384 | |
| 2009-09-11 17:18 | Bill Hoffman | Status | new => assigned |
| 2009-09-11 17:18 | Bill Hoffman | Assigned To | => Bill Hoffman |
| 2010-08-29 10:38 | Kovarththanan Rajaratnam | Category | CMake => Modules |
| 2016-06-10 14:27 | Kitware Robot | Note Added: 0041592 | |
| 2016-06-10 14:27 | Kitware Robot | Status | assigned => resolved |
| 2016-06-10 14:27 | Kitware Robot | Resolution | open => moved |
| 2016-06-10 14:30 | Kitware Robot | Status | resolved => closed |
| Issue History |
| Copyright © 2000 - 2018 MantisBT Team |