[cmake-developers] module merge mania

[Brad King]

Alexander Neundorf wrote:
> On Tuesday 19 September 2006 22:03, Brad King wrote:
>> Alexander Neundorf wrote:
>>> Don't want to be annoying, but e.g. for check_include_files() there is
>>> only one version, a C version.
>>> So maybe an extra C++ version isn't actually required ?
>> That macro was written before it was realized that separate C and C++
>> versions are needed.  Please create separate versions.  They run
>> different native tools.
> 
> Another alternative to CHECK_C_STRUCT_MEMBER() would be 
> C_CHECK_STRUCT_MEMBER() 
> 
> Which one do you prefer ?

How about CHECK_STRUCT_MEMBER_C and CHECK_STRUCT_MEMBER_CXX?

> And for macro_push_required_vars(), I managed to make it work also with 
> multiple push and pops.

Great.

> Under which name can I add it to cmake ?
> PUSH_REQUIRED_VARS() in the file PushRequiredVars.cmake ?

This is used to save/restore variables providing values to other CHECK_*
macros, right?  Perhaps the macros should be named PUSH_CHECK_STATE and
POP_CHECK_STATE.

> In KDE we have a file MacroLibrary.cmake which just includes all other 
> macro_xxx() files.

I think we should just include the macros we need and they can include
their dependencies.

-Brad