[CMake] Modified FindDCMTK

Thomas Sondergaard ts at medical-insight.com
Fri Jun 11 05:07:25 EDT 2010


Ryan Pavlik wrote:
> On 06/10/2010 03:28 PM, Thomas Sondergaard wrote:
>> The FindDCMTK.cmake module in the git master branch doesn't find all 
>> the dcmtk libraries. I've attached a modified version of FindDCMTK 
>> that finds all the dcmtk libraries. It is also about 25% smaller as 
>> some duplicated code has been unified using FOREACH.
>>
>> I hope you will consider including it in the CMake distribution.
>>
>> Regards,
>>
>> Thomas Sondergaard 
> I ran it through my cleanup tool and made two manual fixes: using 
> list(APPEND where appropriate, and using the plural INCLUDE_DIRS.  It 
> could be further improved by using the find_package_handle_standard_args 
> macro.
> 
> I've attached my update of your file.
> 
> Ryan
> 

Thanks for the update and suggestions. I've attached a new version and a 
diff between your version and my new version.

Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: FindDCMTK.cmake.diff
Type: text/x-patch
Size: 1509 bytes
Desc: not available
URL: <http://www.cmake.org/pipermail/cmake/attachments/20100611/57d544c5/attachment.bin>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: FindDCMTK.cmake
URL: <http://www.cmake.org/pipermail/cmake/attachments/20100611/57d544c5/attachment.asc>


More information about the CMake mailing list