[CMake] Diff output from CMake?

Eric Noulard eric.noulard at gmail.com
Tue Sep 13 18:23:27 EDT 2011


2011/9/13 Clifford Yapp <cliffyapp at gmail.com>:
> Eric -
>
> Excellent!  That looks like it will do the trick.
>
> Thank you!

Please tell us about the performance but from the implementation of REMOVE_ITEM
I bet the performance shouldn't be that good:

inside cmListCommand.cxx:

bool cmListCommand
::HandleRemoveItemCommand(std::vector<std::string> const& args)

is using std::vector<std::string> (as Alex said) but the algorithm
used for ITEM removal seems suboptimal.

The two for loops may be merged in a single loop and avoid the
erase call alltogether.


If you are hitting a performance wall with the REMOVE_ITEM solution
you may try to patch that.

-- 
Erk
Membre de l'April - « promouvoir et défendre le logiciel libre » -
http://www.april.org


More information about the CMake mailing list