<br><br><div class="gmail_quote">On Fri, May 9, 2008 at 7:04 PM, Philip Lowman <<a href="mailto:philip@yhbt.com">philip@yhbt.com</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d">On Fri, May 9, 2008 at 4:12 PM, Alexander Neundorf <<a href="mailto:a.neundorf-work@gmx.net" target="_blank">a.neundorf-work@gmx.net</a>> wrote:<br></div><div class="gmail_quote"><div class="Ih2E3d">
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div></div><div>On Friday 09 May 2008, Philip Lowman wrote:<br>
> Should the pkg_check_modules() included with CMake 2.6.0 in<br>
> FindPkgConfig.cmake return full path declarations for <XPREFIX>_LIBRARIES<br>
> and <XPREFIX>_STATIC_LIBRARIES instead of just NameA;NameB;NameC ?<br>
><br>
> This would make an extremely useful feature in my book in trying to port<br>
> stuff to CMake <a href="http://2.6.0." target="_blank">2.6.0.</a> Anyone else agree?<br>
<br>
</div></div>Yes, I do.</blockquote></div><div><br>I implemented it. I could use feedback and testing. It seems to work fine for me and plays very nicely with CMake's new file-extension based find_library support and full path target_link_libraries support. Here are the changes:<br>
<br>1. <XPREFIX>_LIBRARIES is now <XPREFIX>_LIBRARIES_NOPATHS.<br></div></div></blockquote><div><br>I'm starting to have second thought about this change. It will cause
backwards compatibility issues if someone is doing something like this:<br>
<br>
LINK_LIBRARIES(/my/custom/path ) # custom path instead of the path provided by FindPkgConfig<br>
TARGET_LINK_LIBRARIES(foo <XPREFIX>_LIBRARIES)<br>
<br>I suppose that the proper thing to do is
modify the patch so <XPREFIX_LIBRARIES> remains unchanged and a new variable is used for the full paths like <XPREFIX>_LIBRARIES_FULLPATHS or something
like that? Comments?<br></div></div><br>-- <br>Philip Lowman