On Fri, Jan 9, 2009 at 7:32 AM, Philip Lowman <span dir="ltr"><<a href="mailto:philip@yhbt.com">philip@yhbt.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d">On Thu, Jan 8, 2009 at 5:22 PM, Albert Astals Cid <span dir="ltr"><<a href="mailto:aacid@kde.org" target="_blank">aacid@kde.org</a>></span> wrote:<br></div><div class="gmail_quote"><div class="Ih2E3d">
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">if (LibOpenJPEG_OPENJPEG_LIBRARY)<br>
set (LibOpenJPEG_LIBRARIES ${openjpeg_LIBRARY})<br>
endif (LibOpenJPEG_OPENJPEG_LIBRARY)</blockquote></div><div><br>If you spot any find modules with this syntax this is wrong. The reason why is if LibOpenJPEG_OPENJPEG_LIBRARY is NOTFOUND then LibOpenJPEG_LIBRARIES will not be set to NOTFOUND and if the user is linking a target against the LIBRARIES variable they will get no error because the variable will expand to nothing.<br>
<br>Please fix this in your new modules and if you see it anywhere report it as a bug.</div></div></blockquote><div><br>Sorry, forgot to add this. By fix I mean drop the conditional:<br><br>set(LibOpenJPEG_LIBRARIES ${openjpeg_LIBRARY}) <br>
<br></div></div>-- <br>Philip Lowman<br>