I must have specified the order of files backwards when I made the patch, the issue is that *currently* in 2.6.4, 2 hyphens happen, my patch is meant to remove hyphens. Looking at trunk though it appears the problem was already found.<br>
<br><div class="gmail_quote">On Tue, Sep 8, 2009 at 3:34 PM, Andreas Pakulat <span dir="ltr"><<a href="mailto:apaku@gmx.de">apaku@gmx.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div></div><div class="h5">On 08.09.09 13:47:56, Joseph Garvin wrote:<br>
> Without this patch FindBoost.cmake will look for the wrong filenames<br>
> when linking against a release build of boost. For debug it looks for<br>
> the correct names, but for release it adds spurious hyphens. It looks<br>
> like the hyphens used to be necessary, then the code changed and<br>
> someone changed debug to match to the change but forgot to update<br>
> release.<br>
><br>
> I'd love to see this in 2.6.5 so I don't have to ship a<br>
> FindBoost.cmake replacement with my app :P<br>
<br>
</div></div>I don't see why this patch would be necessary. The<br>
boost_(MULTITHREAD|STATIC|ABI|COMPILER) variables already start with a<br>
hyphen, so your patch will add 2 hyphens to the names that are being<br>
searched.<br>
<br>
There's a difference between the debug and the release find_library<br>
calls, but thats just adding _boost_ABI_TAG in the debug-case.<br>
<br>
This is with CMake from the 2.6 branch<br>
<br>
Andreas<br>
<br>
--<br>
It may or may not be worthwhile, but it still has to be done.<br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the CMake FAQ at: <a href="http://www.cmake.org/Wiki/CMake_FAQ" target="_blank">http://www.cmake.org/Wiki/CMake_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.cmake.org/mailman/listinfo/cmake" target="_blank">http://www.cmake.org/mailman/listinfo/cmake</a><br>
</blockquote></div><br>