On Thu, Dec 17, 2009 at 3:20 AM, Michael Wild <span dir="ltr"><<a href="mailto:themiwi@gmail.com">themiwi@gmail.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im"><br>
On 16. Dec, 2009, at 20:35 , Michael Jackson wrote:<br>
<br>
> I am intrigued by the "ExternalProject" feature of CMake 2.8. One question that I have after reading through the Oct 09 "Kitware Source" is this. If I do a "make clean" or "rebuild" are all the "ExternalProjects" also cleaned/rebuilt? I could make an argument both ways but I was curious what the default was?<br>
><br>
> One of my projects depends on HDF5, Tiff, Expat and Boost (And Qt Eventually). Writing directions to get everything downloaded and built is getting to be a pain. Would be simpler to have all that done for the user.<br>
><br>
> Thanks for any comments<br>
> _________________________________________________________<br>
> Mike Jackson <a href="mailto:mike.jackson@bluequartz.net">mike.jackson@bluequartz.net</a><br>
> BlueQuartz Software <a href="http://www.bluequartz.net" target="_blank">www.bluequartz.net</a><br>
> Principal Software Engineer Dayton, Ohio<br>
><br>
<br>
</div>"make clean" behaves a bit strange for me... It seems to remove some of the stamp files, but does not actually perform a "clean" on the external project, or wipe the extracted sources. For me, this is a bit of a problem, since the PATCH_COMMAND will try to re-apply a patch, which of course will fail. Not sure how to teach CMake to not re-patch a source tree... Perhaps wrap the whole thing in a apply_patch.cmake script which creates its own stamp in the external source tree and only applies the patch if that stamp does not exist...<br>
<font class="Apple-style-span" color="#888888"><br></font></blockquote><div><br></div><div>Michael Wild's observations are correct. The "make clean" of the outer project is going to wipe all the stamp files causing all of the steps to re-run again, including downloads and checkouts.</div>
<div><br></div><div>Since the patch command is empty by default and 'patch' is not readily available on Windows, the patching stuff is less well tested than the rest of the steps.</div><div><br></div><div>I guess I would be inclined to say that an outer/main-project "make clean" ought to default to cleaning the inner/nested/external projects as well... but it's not clear to me that there's a reasonable way to implement that quickly and easily. It's certainly worthy of a feature request and some discussion. And whatever the default behavior is, it should probably be controllable by one or more new arguments to the ExternalProject_Add function.</div>
<div><br></div><div>Let me know if you have further ideas and suggestions.</div><div><br></div><div><br></div><div>Thanks,</div><div>David Cole</div><div><br></div></div>