The wiki page that lists module maintainers is found here:<div><a href="http://www.itk.org/Wiki/CMake:Module_Maintainers">http://www.itk.org/Wiki/CMake:Module_Maintainers</a></div><div><br></div><div>For FindSubversion.cmake, <span class="Apple-style-span" style="font-family: sans-serif; font-size: 13px; line-height: 19px; ">Tristan Carel is listed as the maintainer.</span><br>
<br></div><div>Perhaps patches for FindSubversion.cmake would more appropriately be added to patch files attached to a bug report / feature request. (And then that bug would be assigned to the module maintainer for whatever module it belongs to.)</div>
<div><br></div><div>Patches tend to get lost in the shuffle on this mailing list.....</div><div><br></div><div><br></div><div>David</div><div><br></div><div><br><div class="gmail_quote">On Thu, Jan 28, 2010 at 4:07 AM, Marcel Loose <span dir="ltr"><<a href="mailto:loose@astron.nl">loose@astron.nl</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">There's a bug in the current FindSubversion.cmake, which causes it to<br>
ignore the REQUIRED option, when option QUIET is not given. The<br>
following patch solves this. IMHO, it would be even better to use FPHSA<br>
for this.<br>
<br>
Furthermore, I'm not sure whether it's desirable to conditionally define<br>
macros. This puts the burden on the user to check Subversion_FOUND<br>
first, before calling, e.g., Subversion_WC_INFO. I'd prefer to do this<br>
inside the macro Subversion_WC_INFO.<br>
<br>
Just my 2 cents.<br>
Marcel Loose.<br>
<br>
<br>
Index: FindSubversion.cmake<br>
===================================================================<br>
RCS file: /cvsroot/CMake/CMake/Modules/FindSubversion.cmake,v<br>
retrieving revision 1.5<br>
diff -u -r1.5 FindSubversion.cmake<br>
--- FindSubversion.cmake 28 Sep 2009 15:45:46 -0000 1.5<br>
+++ FindSubversion.cmake 28 Jan 2010 08:54:18 -0000<br>
@@ -110,13 +110,13 @@<br>
ENDIF(Subversion_SVN_EXECUTABLE)<br>
<br>
IF(NOT Subversion_FOUND)<br>
- IF(NOT Subversion_FIND_QUIETLY)<br>
- MESSAGE(STATUS "Subversion was not found.")<br>
- ELSE(NOT Subversion_FIND_QUIETLY)<br>
- IF(Subversion_FIND_REQUIRED)<br>
- MESSAGE(FATAL_ERROR "Subversion was not found.")<br>
- ENDIF(Subversion_FIND_REQUIRED)<br>
- ENDIF(NOT Subversion_FIND_QUIETLY)<br>
+ IF(Subversion_FIND_REQUIRED)<br>
+ MESSAGE(FATAL_ERROR "Subversion was not found.")<br>
+ ELSE(Subversion_FIND_REQUIRED)<br>
+ IF(NOT Subversion_FIND_QUIETLY)<br>
+ MESSAGE(STATUS "Subversion was not found.")<br>
+ ENDIF(NOT Subversion_FIND_QUIETLY)<br>
+ ENDIF(Subversion_FIND_REQUIRED)<br>
ENDIF(NOT Subversion_FOUND)<br>
<br>
# FindSubversion.cmake ends here.<br>
<br>
<br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the CMake FAQ at: <a href="http://www.cmake.org/Wiki/CMake_FAQ" target="_blank">http://www.cmake.org/Wiki/CMake_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.cmake.org/mailman/listinfo/cmake" target="_blank">http://www.cmake.org/mailman/listinfo/cmake</a><br>
</blockquote></div><br></div>