Aaron,<div><br></div><div>Thanks for posting. Could you open a new bug report and attach your patch to it?</div><div><br></div><div><div class="gmail_quote">On Wed, Sep 29, 2010 at 9:33 PM, <span dir="ltr"><<a href="mailto:aaron.meadows@thomsonreuters.com">aaron.meadows@thomsonreuters.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold">Hi all.
I noticed that CMakeDetermineVSServicePack.cmake only supports vs2005, vs2005
sp1, vs2008, vs2008 sp1. I wanted to use it for vs2010.</span></font></b></p>
<p class="MsoNormal"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold"> </span></font></b></p>
<p class="MsoNormal"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold">I looked
for a bug but the only one I found was the one that resulted in the scripts
creation: <a href="http://public.kitware.com/Bug/view.php?id=8803" target="_blank">http://public.kitware.com/Bug/view.php?id=8803</a></span></font></b></p>
<p class="MsoNormal"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold"> </span></font></b></p>
<p class="MsoNormal"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold">I have a
patch to fix it: (also attached)</span></font></b></p>
<p class="MsoNormal"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold"> </span></font></b></p>
<p class="MsoNormal" style="margin-left:.5in"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold">*** CMakeDetermineVSServicePack.cmake 2010-06-28
09:42:36.000000000 -0500</span></font></b></p>
<p class="MsoNormal" style="margin-left:.5in"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold">--- CMakeDetermineVSServicePackWith2010.cmake 2010-09-29
20:26:20.530212900 -0500</span></font></b></p>
<p class="MsoNormal" style="margin-left:.5in"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold">***************</span></font></b></p>
<p class="MsoNormal" style="margin-left:.5in"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold">*** 47,52 ****</span></font></b></p>
<p class="MsoNormal" style="margin-left:.5in"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold">--- 47,54 ----</span></font></b></p>
<p class="MsoNormal" style="margin-left:.5in"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold"> set(_version "vc90")</span></font></b></p>
<p class="MsoNormal" style="margin-left:.5in"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold"> elseif(${_cl_version} VERSION_EQUAL
"15.00.30729.01")</span></font></b></p>
<p class="MsoNormal" style="margin-left:.5in"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold"> set(_version "vc90sp1")</span></font></b></p>
<p class="MsoNormal" style="margin-left:.5in"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold">+ elseif(${_cl_version} VERSION_EQUAL
"16.00.30319.01")</span></font></b></p>
<p class="MsoNormal" style="margin-left:.5in"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold">+ set(_version "vc100")</span></font></b></p>
<p class="MsoNormal" style="margin-left:.5in"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold"> else()</span></font></b></p>
<p class="MsoNormal" style="margin-left:.5in"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold"> set(_version "")</span></font></b></p>
<p class="MsoNormal" style="margin-left:.5in"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold"> endif()</span></font></b></p>
<p class="MsoNormal"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold"> </span></font></b></p>
<p class="MsoNormal"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold">Should I
open a new bug for this and add a patch to it, or reopen the old bug (feature
request) with this patch?</span></font></b></p>
<p class="MsoNormal"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold"> </span></font></b></p>
<p class="MsoNormal"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold">Thanks!</span></font></b></p>
<p class="MsoNormal"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold"> </span></font></b></p>
<p class="MsoNormal"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold">--aaron</span></font></b></p>
<p class="MsoNormal"><b><font size="2" color="gray" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:gray;font-weight:bold"> </span></font></b></p>
<div style="border:none;border-top:dotted silver 1.0pt;padding:4.0pt 0in 0in 0in">
<p class="MsoNormal"><b><font size="1" color="#666666" face="Arial"><span style="font-size:9.0pt;font-family:Arial;color:#666666;font-weight:bold">Aaron
Meadows</span></font></b><font size="1" color="#666666" face="Arial"><span style="font-size:9.0pt;font-family:Arial;color:#666666"><br>
Software Engineer</span></font></p>
<p style="margin-right:0in;margin-bottom:9.0pt;margin-left:0in"><b><font size="1" color="#f57f20" face="Arial"><span style="font-size:9.0pt;font-family:Arial;color:#F57F20;font-weight:bold">Thomson
Reuters</span></font></b></p>
<p class="MsoNormal"><font size="1" color="#666666" face="Arial"><span style="font-size:9.0pt;font-family:Arial;color:#666666">Phone: 314.468.3530<br>
Mobile:
636.541.6139<br>
<a href="mailto:aaron.meadows@thomsonreuters.com" target="_blank">aaron.meadows@thomsonreuters.com</a><br>
<a href="http://thomsonreuters.com" target="_blank">thomsonreuters.com</a></span></font><font size="1" color="#666666" face="Arial"><span style="font-size:9.0pt;font-family:Arial;color:#666666"></span></font></p>
</div>
<p class="MsoNormal"><font size="3" face="Times New Roman"><span style="font-size:12.0pt"> </span></font></p>
</div>
<br clear="all"> This email was sent to you by Thomson Reuters, the global news and information company.<br>
Any views expressed in this message are those of the individual sender, except where the sender specifically states them to be the views of Thomson Reuters.
</div>
<br>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the CMake FAQ at: <a href="http://www.cmake.org/Wiki/CMake_FAQ" target="_blank">http://www.cmake.org/Wiki/CMake_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.cmake.org/mailman/listinfo/cmake" target="_blank">http://www.cmake.org/mailman/listinfo/cmake</a><br></blockquote></div><br><br clear="all"><br>-- <br>Philip Lowman<br>
</div>