<br><br><div class="gmail_quote">On Tue, Nov 23, 2010 at 6:02 PM, David Cole <span dir="ltr"><<a href="mailto:david.cole@kitware.com">david.cole@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
It might be due to this commit:<br>
<a href="http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=142edf8ad4baccd991a6a8a3e5283d0b575acca2" target="_blank">http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=142edf8ad4baccd991a6a8a3e5283d0b575acca2</a><br>
(first released in 2.8.3)<br>
<br>
Or this one:<br>
<a href="http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b4d27dc041c9164d6f3ad39e192f4b7d116ca3b3" target="_blank">http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b4d27dc041c9164d6f3ad39e192f4b7d116ca3b3</a><br>
(first released in 2.8.2)<br>
<br>
Either way, seems like a bug to me. If you explicitly specify a COST<br>
property value, especially a negative one to induce "last run" status,<br>
then it should be honored over either historical average measurement<br>
or "failed last time, so run it first this time" behavior.<br>
<br>
Zach, do you agree?<br>
<br></blockquote><div>Sure do, this is a bug. I'll take a look at it today.</div><div><br></div><div>-Zach </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
Thanks,<br>
David<br>
<br>
<br>
On Tue, Nov 23, 2010 at 5:36 PM, Tyler Roscoe <<a href="mailto:tyler@cryptio.net">tyler@cryptio.net</a>> wrote:<br>
> I use set_tests_properties (... COST -500) to force my code coverage<br>
> checks to run after all the unit tests have run. This has stopped<br>
> working and I'm reasonably confident that the only thing that changed<br>
> was an upgrade from cmake 2.8.0 or 2.8.1 to 2.8.3.<br>
><br>
> I couldn't find anything in the bug tracker or in the release notes<br>
> suggesting that COST or test properties were changed in 2.8.3.<br>
><br>
> I'm still getting lines like this in my generated CTestTestfile.cmake:<br>
><br>
> SET_TESTS_PROPERTIES(rs_exerciser_2dgrid PROPERTIES COST "-500" FAIL_REGULAR_EXPRESSION "TP_EXERCISER_FAIL")<br>
><br>
> and the FAIL_REGULAR_EXPRESSION property seems to be working just fine.<br>
><br>
><br>
> I've included a small repro case below. This looks like a regression. Should I<br>
> open a bug?<br>
><br>
> Thanks,<br>
> tyler<br>
><br>
><br>
> [tylermr@tpb006:~/cmake-test-properties-test]$ cat CMakeLists.txt<br>
> cmake_minimum_required(VERSION 2.8)<br>
> project(p)<br>
> enable_testing()<br>
><br>
> add_test (i_should_run_second echo i should run second)<br>
> set_tests_properties (i_should_run_second PROPERTIES COST -1)<br>
> add_test (i_should_run_first echo i should run first)<br>
><br>
> [tylermr@tpb006:~/cmake-test-properties-test]$ mkdir b && cd b && cmake ..<br>
> -- The C compiler identification is GNU<br>
> -- The CXX compiler identification is GNU<br>
> -- Check for working C compiler: /usr/bin/gcc<br>
> -- Check for working C compiler: /usr/bin/gcc -- works<br>
> -- Detecting C compiler ABI info<br>
> -- Detecting C compiler ABI info - done<br>
> -- Check for working CXX compiler: /usr/bin/c++<br>
> -- Check for working CXX compiler: /usr/bin/c++ -- works<br>
> -- Detecting CXX compiler ABI info<br>
> -- Detecting CXX compiler ABI info - done<br>
> -- Configuring done<br>
> -- Generating done<br>
> -- Build files have been written to: /tpb006/tylermr/cmake-test-properties-test/b<br>
><br>
> [tylermr@tpb006:~/cmake-test-properties-test/b]$ ctest --version<br>
> ctest version 2.8.3<br>
> [tylermr@tpb006:~/cmake-test-properties-test/b]$ ctest<br>
> Test project /tpb006/tylermr/cmake-test-properties-test/b<br>
> Start 1: i_should_run_second<br>
> 1/2 Test #1: i_should_run_second .............. Passed 0.01 sec<br>
> Start 2: i_should_run_first<br>
> 2/2 Test #2: i_should_run_first ............... Passed 0.01 sec<br>
><br>
> 100% tests passed, 0 tests failed out of 2<br>
><br>
> Total Test time (real) = 0.04 sec<br>
><br>
> [tylermr@tpb006:~/cmake-test-properties-test/b]$ /usr/local/cmake-2.8.1-Linux-i386/bin/ctest --version<br>
> ctest version 2.8.1<br>
> [tylermr@tpb006:~/cmake-test-properties-test/b]$ /usr/local/cmake-2.8.1-Linux-i386/bin/ctest<br>
> Test project /tpb006/tylermr/cmake-test-properties-test/b<br>
> Start 2: i_should_run_first<br>
> 1/2 Test #2: i_should_run_first ............... Passed 0.01 sec<br>
> Start 1: i_should_run_second<br>
> 2/2 Test #1: i_should_run_second .............. Passed 0.01 sec<br>
><br>
> 100% tests passed, 0 tests failed out of 2<br>
><br>
> Total Test time (real) = 0.02 sec<br>
><br>
> _______________________________________________<br>
> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
><br>
> Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
><br>
> Please keep messages on-topic and check the CMake FAQ at: <a href="http://www.cmake.org/Wiki/CMake_FAQ" target="_blank">http://www.cmake.org/Wiki/CMake_FAQ</a><br>
><br>
> Follow this link to subscribe/unsubscribe:<br>
> <a href="http://www.cmake.org/mailman/listinfo/cmake" target="_blank">http://www.cmake.org/mailman/listinfo/cmake</a><br>
><br>
</blockquote></div><br><br><br>