Hi Brad,<div><br><div class="gmail_quote">On Mon, Feb 7, 2011 at 7:14 PM, Brad King <span dir="ltr"><<a href="mailto:brad.king@kitware.com">brad.king@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hi Johan,<br>
<br>
Let's move this over to the developers' list. I'm cc-ing the users' list<br>
just for this transition message. Thanks.<br>
<div class="im"><br>
On 02/05/2011 06:50 PM, Johan Björk wrote:<br>
> The fix is extremely simple, in cmCTestGIT.cxx:266<br>
> char const* git_submodule[] = {git, "submodule", "update", 0};<br>
> modify to<br>
> char const* git_submodule[] = {git, "submodule", "update",<br>
> "--recursive", 0};<br>
<br>
</div>This would be a nice approach, but the --recursive option was added in<br>
Git 1.6.5, released 2009-10-10. Versions older than that were still<br>
in common use when the submodule update code was added on 2010-05-04:<br>
<br>
<a href="http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=67277bac" target="_blank">http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=67277bac</a><br>
<br>
and may still be. We have a few options:<br>
<br>
(1) Hard-code --recursive and add a check to error out if the Git<br>
version is not new enough.<br>
<br>
(2) Test the Git version and pass --recursive only if new enough.<br>
This could lead to subtle behavior differences between Git versions,<br>
but perhaps we could print a warning.<br>
<br>
(3) Add an interface to specify options for the invocation of the<br>
submodule update command.<br>
<br>
Comments?<br>
<font color="#888888">-Brad<br></font></blockquote><div>(2) seems both complicated and confusing for end users. I would vote for (1) as if someone updates to the latest CMake on their machine, they shouldn't have any issues in upgrading the git version in use.</div>
<div><br></div><div><br></div><div>/Johan</div><div> </div></div></div><div><br></div>