Aaron,<div><br></div><div>Thanks. Please see my comments in the ticket you reopened with the patch you sent in yesterday.</div><div><br></div><div>BTW -- If you would like to volunteer to take ownership of this module I would be happy to hand it over to someone else. Since I no longer use Visual Studio I'm probably the wrong maintainer for this module.</div>
<div><a href="http://www.itk.org/Wiki/CMake:Module_Maintainers">http://www.itk.org/Wiki/CMake:Module_Maintainers</a></div><div><br><br><div class="gmail_quote">On Tue, Jun 7, 2011 at 1:53 PM, <span dir="ltr"><<a href="mailto:aaron.meadows@thomsonreuters.com">aaron.meadows@thomsonreuters.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div lang="EN-US" link="blue" vlink="purple"><div><p class="MsoNormal"><span><span style="font-size:10.0pt;color:black">I’ve reopened Issue 0011279. CMakeDetermineVSServicePack.cmake has been broken again, this time by VS2010 switching to MSBuild. This has caused the version string to change. I’ve created a patch and uploaded it to the Issue:</span></span></p>
<p class="MsoNormal"><span><span style="font-size:10.0pt;color:black"> </span></span></p><p class="MsoNormal"><span><span style="font-size:10.0pt;color:black">------------------------------8</span></span><span><span style="font-size:10.0pt;font-family:Wingdings;color:black">ß</span></span><span><span style="font-size:10.0pt;color:black">-------------------------------------------------</span></span></p>
<p class="MsoNormal"><span><span style="font-size:10.0pt;color:black"> </span></span></p><p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black">--- CMakeDetermineVSServicePack.cmake 2011-06-06 17:40:02.955552300 -0500</span></span></p>
<p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black">+++ CMakeDetermineVSServicePackWithVS2010MSBuild.cmake 2011-06-06 17:47:<a href="tel:04.057552300" value="+14057552300" target="_blank">04.057552300</a> -0500</span></span></p>
<p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black">@@ -47,7 +47,9 @@</span></span></p><p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black"> set(_version "vc90")</span></span></p>
<p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black"> elseif(${_cl_version} VERSION_EQUAL "<a href="tel:15.00.30729.01" value="+15003072901" target="_blank">15.00.30729.01</a>")</span></span></p>
<p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black"> set(_version "vc90sp1")</span></span></p><p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black">- elseif(${_cl_version} VERSION_EQUAL "<a href="tel:16.00.30319.01" value="+16003031901" target="_blank">16.00.30319.01</a>")</span></span></p>
<p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black">+ elseif(${_cl_version} VERSION_EQUAL "<a href="tel:16.00.30319.01" value="+16003031901" target="_blank">16.00.30319.01</a>") # Pre-release VS2010 version number</span></span></p>
<p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black">+ set(_version "vc100pre")</span></span></p><p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black">+ elseif(${_cl_version} VERSION_EQUAL "4.00.30319.01") # Release version of VS2010 which uses MSBuild version number</span></span></p>
<p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black"> set(_version "vc100")</span></span></p><p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black"> else()</span></span></p>
<p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black"> set(_version "")</span></span></p><p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black">@@ -74,6 +76,13 @@</span></span></p>
<p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black"> if(DETERMINED_VS_SERVICE_PACK AND _output)</span></span></p><p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black"> string(REGEX MATCH "Compiler Version [0-9]+.[0-9]+.[0-9]+.[0-9]+"</span></span></p>
<p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black"> _cl_version "${_output}")</span></span></p><p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black">+</span></span></p>
<p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black">+ # If the above didn't work, this may be VS 2010, which has a different output with MSBuild</span></span></p><p class="MsoNormal">
<span><span style="font-size:10.0pt;font-family:Consolas;color:black">+ if(NOT _cl_version)</span></span></p><p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black">+ string(REGEX MATCH "Build Engine Version [0-9]+.[0-9]+.[0-9]+.[0-9]+"</span></span></p>
<p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black">+ _cl_version "${_output}")</span></span></p><p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black">+ endif()</span></span></p>
<p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black">+</span></span></p><p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black"> if(_cl_version)</span></span></p>
<p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black"> string(REGEX MATCHALL "[0-9]+"</span></span></p><p class="MsoNormal"><span><span style="font-size:10.0pt;font-family:Consolas;color:black"> _cl_version_list "${_cl_version}")</span></span></p>
<p class="MsoNormal"><span><span style="font-size:10.0pt;color:black"> </span></span></p><p class="MsoNormal"> </p><p class="MsoNormal"> </p><div style="border:none;border-top:dotted silver 1.0pt;padding:4.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:9.0pt;color:#666666">Aaron Meadows</span></b><span style="font-size:9.0pt;color:#666666"><br>Software Engineer</span></p><p class="MsoNormal" style="margin-right:0in;margin-bottom:9.0pt;margin-left:0in">
<b><span style="font-size:9.0pt;color:#F57F20">Thomson Reuters</span></b></p></div><p class="MsoNormal"><span style="font-size:9.0pt;color:#666666">Phone: <a href="tel:314.468.3530" value="+13144683530" target="_blank">314.468.3530</a><br>
Mobile: <a href="tel:636.541.6139" value="+16365416139" target="_blank">636.541.6139</a><br><a href="mailto:aaron.meadows@thomsonreuters.com" target="_blank">aaron.meadows@thomsonreuters.com</a><br><font color="#888888"><a href="http://thomsonreuters.com" target="_blank">thomsonreuters.com</a></font></span></p>
</div></div><br>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the CMake FAQ at: <a href="http://www.cmake.org/Wiki/CMake_FAQ" target="_blank">http://www.cmake.org/Wiki/CMake_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.cmake.org/mailman/listinfo/cmake" target="_blank">http://www.cmake.org/mailman/listinfo/cmake</a><br></blockquote></div><br><br clear="all"><br>-- <br>Philip Lowman<br>
</div>