<div class="gmail_quote">On Thu, Jul 7, 2011 at 8:05 AM, Michael Hertling <span dir="ltr"><<a href="mailto:mhertling@online.de">mhertling@online.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On 07/07/2011 12:23 AM, David Cole wrote:<br>
> Many people care. Few have time to respond to everything on the CMake<br>
> mailing list...<br>
><br>
> This is how to become a CMake module maintainer if it is necessary:<br>
> <a href="http://www.cmake.org/Wiki/CMake:Module_Maintainers" target="_blank">http://www.cmake.org/Wiki/CMake:Module_Maintainers</a><br>
><br>
> Looks like Eric Wing is the maintainer for the other SDL related find<br>
> modules. I'll forward this to him to see what he says...<br>
><br>
><br>
> Cheers,<br>
> David<br>
><br>
><br>
> On Wed, Jul 6, 2011 at 6:16 PM, David Demelier <<a href="mailto:demelier.david@gmail.com">demelier.david@gmail.com</a>>wrote:<br>
><br>
>> On 29/06/2011 21:49, David Demelier wrote:<br>
>><br>
>>> Hello cmake users,<br>
>>><br>
>>> I don't know how users usually send new modules so I try by mail. I made<br>
>>> a cmake module for SDL_gfx library<br>
</div>>>> (<a href="http://www.ferzkopp.net/**Software/SDL_gfx-2.0/" target="_blank">http://www.ferzkopp.net/**Software/SDL_gfx-2.0/</a><<a href="http://www.ferzkopp.net/Software/SDL_gfx-2.0/" target="_blank">http://www.ferzkopp.net/Software/SDL_gfx-2.0/</a>><br>
<div class="im">>>> )<br>
>>><br>
>>> It's not a SDL official library but it is popular and a lot of games are<br>
>>> using it.<br>
>>><br>
>>> The FindSDL_gfx.cmake module found as attachment is inspired by<br>
>>> FindSDL_mixer.cmake because they are very similar.<br>
>>><br>
>>> Cheers,<br>
>>><br>
>>><br>
>> Nobody cares :(<br>
>><br>
>> --<br>
>> David Demelier<br>
<br>
</div>Just a few remarks on my part:<br></blockquote><div><br>Thanks, Michael.<br><br> <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
(1) FindSDL_gfx.cmake does not handle the QUIET and particularly the<br>
REQUIRED flag, e.g. by FIND_PACKAGE_HANDLE_STANDARD_ARGS(). The other<br>
SDL-related find modules including FindSDL.cmake itself do not either.<br>
<br>
(2) FindSDL_gfx.cmake does not adhere to the recommendations in<br>
${CMAKE_ROOT}/Modules/readme.txt w.r.t. the result variables, i.e.<br>
there's no non-cached variable ending in *_LIBRARIES containing the<br>
package's library including its prerequisites. The other SDL-related<br>
find modules including FindSDL.cmake itself do not either. The latter<br>
(mis)uses the cached SDL_LIBRARY variable to contain prerequisites for<br>
the actual SDL library and command line switches for the linker, and<br>
FindSDL_sound.cmake - providing an SDL_SOUND_LIBRARIES variable -<br>
puts this variable in the cache where it does not belong.<br>
<br></blockquote><div><br>(1) and (2) are both filled with excellent points.<br><br> <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
(3) Instead of adding the nth FindSDL_xyz.cmake module, wouldn't it be<br>
preferable to invest the time, work and brain in the development of a<br>
nice single, standard-compliant and multi-component-aware find module<br>
for SDL and friends with components, say, core/main/mixer/gfx etc.?<br>
<br></blockquote><div><br>Indeed, it would be preferable. Actually, I would prefer it if all of the Find modules were installed as part of the project that they represent rather than being in CMake itself. If a project has a standard/conventional default installation location, CMake's find_package is perfectly content to pull the find module from the project's own install tree. These things really belong distributed out in the projects they represent, not in CMake itself.<br>
<br>Thanks for your continued effort on the CMake mailing list, Michael. Your depth of CMake knowledge is mucho appreciated.<br><br><br>David<br></div></div><br>