On Thu, Dec 29, 2011 at 9:15 PM, Alan W. Irwin <span dir="ltr"><<a href="mailto:irwin@beluga.phys.uvic.ca">irwin@beluga.phys.uvic.ca</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On 2011-12-29 18:34-0500 David Cole wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I've considered your plea, but after looking at the diffs between 2.8.5 and 2.8.7-rc2, I think we ought to keep what we have and<br>
continue moving forward with it.<br>
<br>
The commits involved are easily seen with these git commands:<br>
<br>
$ gitk v2.8.5..a1c9de56 -- Modules/FindLAPACK.cmake Modules/FindBLAS.cmake <br>
<br>
$ git log --oneline v2.8.5..a1c9de56 -- Modules/FindLAPACK.cmake Modules/FindBLAS.cmake <br>
<br>
b3c42cb FindLAPACK: List thread libs to avoid link errors (#12625)<br>
f603cf2 FindLAPACK: Correct CMAKE_FIND_LIBRARY_SUFFIXES spelling (#12624)<br>
f44f053 FindLAPACK: Fix linking to static LAPACK on Unix (#12477)<br>
0cc8f05 FindBLAS/LAPACK fixes<br>
145de0a FindBLAS/LAPACK fixes<br>
cfad24a fixed: search of ATLAS library for C/C++-only projects<br>
d5e6030 ACML-GPU supportede<br>
af4c58b ACML-GPU supported<br>
91b76e2 gotoblas supported<br>
66a4bd0 fixed: search of acml libraries<br>
<br>
I think the fixes that these commits represent outweigh the issue you've raised here late in the game. Especially since 7 of those<br>
commits are already in the 2.8.6 release.<br>
</blockquote>
<br></div>
Hi Dave:<br>
<br>
I was surprised you didn't take the conservative course here since<br>
that is the CMake tradition for dealing with regressions, and the find<br>
modules for lapack/blas are dealing with a particularly complicated<br>
lapack/blas ecosystem where it is easy for these find modules to go wrong<br>
for some platforms. However, I also recognize that this is your<br>
judgement call to make, and I do hope that you are correct that the<br>
benefit of these post-2.8.5 changes is really worth the cost of the<br>
lapack/blas library inconsistency regression that was introduced by<br>
the changes.<br>
<br>
I will try to come up with a fix for the regression early in the next<br>
release cycle and run it by the lapack/blas find module maintainer,<br>
Alexey Ozeritsky.<div class="HOEnZb"><div class="h5"><br>
<br>
Alan<br>
__________________________<br>
Alan W. Irwin<br>
<br>
Astronomical research affiliation with Department of Physics and Astronomy,<br>
University of Victoria (<a href="http://astrowww.phys.uvic.ca" target="_blank">astrowww.phys.uvic.ca</a>).<br>
<br>
Programming affiliations with the FreeEOS equation-of-state<br>
implementation for stellar interiors (<a href="http://freeeos.sf.net" target="_blank">freeeos.sf.net</a>); the Time<br>
Ephemerides project (<a href="http://timeephem.sf.net" target="_blank">timeephem.sf.net</a>); PLplot scientific plotting<br>
software package (<a href="http://plplot.sf.net" target="_blank">plplot.sf.net</a>); the libLASi project<br>
(<a href="http://unifont.org/lasi" target="_blank">unifont.org/lasi</a>); the Loads of Linux Links project (<a href="http://loll.sf.net" target="_blank">loll.sf.net</a>);<br>
and the Linux Brochure Project (<a href="http://lbproject.sf.net" target="_blank">lbproject.sf.net</a>).<br>
__________________________<br>
<br>
Linux-powered Science<br>
__________________________<br>
</div></div></blockquote></div><br><div><br></div><div>There is no conservative course here. There is a choice of whether to make CMake 2.8.7 behave the same as 2.8.6 or the same as 2.8.5.</div><div><br></div><div>For this to be a showstopper it would have had to be reported before we tagged 2.8.6 -- since it is now already in 2.8.6, it should simply be considered a bug that we will try to address as soon as possible and get it merged into master in time for the following release.</div>
<div><br></div><div>It would also be nice if this were more than simply a back-and-forth discussion between you and I. I would sure appreciate more input from other LAPACK and BLAS clients. I will take this as a personal lesson not to schedule a release of any kind the week in between Christmas and New Year's. If we stick to our schedule throughout the coming year, I'll make sure that the December release of CMake next year is well *before* Christmas.</div>
<div><br></div><div><br></div><div>Thanks,</div><div>David</div><div><br></div>