On Wed, Feb 8, 2012 at 3:20 AM, Andreas Schneider <span dir="ltr"><<a href="mailto:asn@cryptomilk.org">asn@cryptomilk.org</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Tuesday 07 February 2012 13:01:49 David Cole wrote:<br>
> 2012/2/7 Nicolas Desprès <<a href="mailto:nicolas.despres@gmail.com">nicolas.despres@gmail.com</a>>:<br>
> > On Sat, Dec 10, 2011 at 3:46 PM, Andreas Schneider <<a href="mailto:asn@cryptomilk.org">asn@cryptomilk.org</a>><br>
wrote:<br>
> >> On Saturday 29 October 2011 23:34:50 Frank Glinka wrote:<br>
> >>> Hi,<br>
> >><br>
> >> Hi,<br>
> ><br>
> > Hi,<br>
> ><br>
> >>> I am happy about the recently improved Java support within cmake.<br>
> >>> Thanks! Anyhow, I have a small point which should be easy to improve and<br>
> >>> which would deliver quite some usability, in my opinion.<br>
> >>><br>
> >>> The current syntax for building and packaging Java files is:<br>
> >>> > add_jar(${TARGETNAME} ${SOURCE_FILES} ${RESOURCE_FILES})<br>
> >>><br>
> >>> This has some drawbacks:<br>
> >>><br>
> >>> 1) No executable jar can be created with that method. It seems there is<br>
> >>> already some effort on that issue as:<br>
> >>> <a href="https://github.com/viandfraich/CMake/commit/36b223e34f5d48339da39e833a2f" target="_blank">https://github.com/viandfraich/CMake/commit/36b223e34f5d48339da39e833a2f</a><br>
</div>> >>> 5e7d f2866e87<br>
<div><div class="h5">> >><br>
> >> I don't like the way how it has been added here. I think it should be an<br>
> >> optional vairable you set before like the others. Please open a feature<br>
> >> request in the bug tracker. Patches are welcome.<br>
> ><br>
> > Here is a proposal:<br>
> > <a href="https://github.com/polrop/CMake/commits/java-executable-jar" target="_blank">https://github.com/polrop/CMake/commits/java-executable-jar</a>><br>
> >>> 2) A jar file can be annotated with a lot of more important information,<br>
> >>> e.g., version information, scope, main-class (would also catch the first<br>
> >>> issue), etc. This information is normally passed as a property/manifest<br>
> >>> file when calling the "jar" packager. Currently, the UseJava.cmake<br>
> >>><br>
> >>> module creates the following command within 'add_jar':<br>
> >>> > jar cf ${TARGETNAME} ${CLASS_FILES} ${RESOURCE_FILES}<br>
> >>><br>
> >>> The following would solve my (and I guess many others') use cases:<br>
> >>> > jar cmf ${TARGETNAME} MyManifest.mf ${CLASS_FILES} ${RESOURCE_FILES}<br>
> >><br>
> >> Should be an optional option and should be done like the other options.<br>
> >><br>
> >> set(CMAKE_JAVA_MANIFEST mymanifest.mf)<br>
> >> add_jar(foo foo.java)<br>
> ><br>
> > I don't have any patch for this issue yet. Maybe in the future.<br>
> ><br>
> >>> An optional command to add_jar would be desirable which allows to<br>
> >>> provide an optional manifest file. If provided, the later syntax should<br>
> >>> be used for calling the 'jar' tool.<br>
> >>><br>
> >>> Will there be progress towards supporting manifest information anytime<br>
> >>> soon within cmake?<br>
> >><br>
> >> Open a feature request in the bugtracker.<br>
> ><br>
> > Please tell me what you think about the proposal.<br>
> ><br>
> > Regards,<br>
> ><br>
> > --<br>
> > Nicolas Desprès<br>
> > --<br>
> ><br>
> > Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
> ><br>
> > Visit other Kitware open-source projects at<br>
> > <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
> ><br>
> > Please keep messages on-topic and check the CMake FAQ at:<br>
> > <a href="http://www.cmake.org/Wiki/CMake_FAQ" target="_blank">http://www.cmake.org/Wiki/CMake_FAQ</a><br>
> ><br>
> > Follow this link to subscribe/unsubscribe:<br>
> > <a href="http://www.cmake.org/mailman/listinfo/cmake" target="_blank">http://www.cmake.org/mailman/listinfo/cmake</a><br>
><br>
> The proposed commits (3 of them, right?) at<br>
> <a href="https://github.com/polrop/CMake/commits/java-executable-jar" target="_blank">https://github.com/polrop/CMake/commits/java-executable-jar</a> look<br>
> reasonable to me.<br>
><br>
> Any objections from people who care about Java to getting these into<br>
> CMake 'next' ...?<br>
<br>
</div></div>Hi,<br>
<br>
David they look good to me. Should I push them to staging or do you want to do<br>
it?<br>
<br>
<br>
Cheers,<br>
<div class="HOEnZb"><div class="h5"><br>
-- andreas<br>
<br>
<br>
--<br>
Andreas Schneider GPG-ID: F33E3FC6<br>
<a href="http://www.cryptomilk.org" target="_blank">www.cryptomilk.org</a> <a href="mailto:asn@cryptomilk.org">asn@cryptomilk.org</a><br>
<br>
</div></div></blockquote></div><br><div>I would love it if you would push them to the stage and merge to 'next'...</div><div><br></div><div>Thx,</div><div>David</div><div><br></div>