<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">For reference I have opened a new
issue:<br>
<a class="moz-txt-link-freetext" href="http://public.kitware.com/Bug/view.php?id=14121">http://public.kitware.com/Bug/view.php?id=14121</a><br>
<br>
Nils<br>
<br>
On 04/25/2013 10:00 PM, Nils Gladitz wrote:<br>
</div>
<blockquote cite="mid:51798B5D.40604@sci-vis.de" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">I was able to reproduce the problem
with Ninja on Ubuntu and CMake 2.8.11-rc2.<br>
<br>
I set up a test project for which I set CTEST_CUSTOM_ERROR_MATCH
to "FooBar".<br>
<br>
It has three custom commands with different outputs and exit
codes:<br>
<br>
CustomCommand1: "this is a FooBar message" (exit success)<br>
CustomCommand2: "this is a fatal error" (exit failure)<br>
CustomCommand3: "this is a FooBar fatal error" (exit
failure)<br>
<br>
These are the results that I got (numbers in braces indicate
which custom commands produce output visible on CDash):<br>
<br>
Ninja (Launchers enabled): 0 Build Errors<br>
Ninja (Launchers disabled): 4 Build Errors (1, 2, 3)<br>
<br>
Unix Makefiles (Launchers enabled): 2 Build Errors (2, 3)<br>
Unix Makefiles (Launchers disabled): 4 Build Errors (1, 2,
3)<br>
<br>
For Unix Makefiles this seems to work better though not quite as
I expected either.<br>
(I expected CustomCommand1 to trigger an error even though the
exit code is 0 due to it having FooBar in the output).<br>
<br>
But if this is by design it would be nice to have at least the
commands with failed exit status show up with Ninja like they do
with Makefiles.<br>
<br>
Hope this helps to diagnose the problem.<br>
<br>
Nils<br>
<br>
On 04/25/2013 07:04 PM, Jean-Christophe Fillion-Robin wrote:<br>
</div>
<blockquote
cite="mid:CANLz8R4bK=MqRhRrUQv+kFr9+EdOt6=MkmxeVn5_Mg1Wk=wJYw@mail.gmail.com"
type="cite">
<div dir="ltr">This is probably caused by commit 965358fcf [1]
<div><br>
</div>
<div style="">Can the problem be reproduced using Ninja on
Unix platform ? </div>
<div>
<div><br>
</div>
<div>[1] <a moz-do-not-send="true"
href="https://github.com/Kitware/CMake/commit/965358fcf64cf1a3693bcdd66f723729e0614ef6">https://github.com/Kitware/CMake/commit/965358fcf64cf1a3693bcdd66f723729e0614ef6</a></div>
</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Thu, Apr 25, 2013 at 12:41 PM,
Nils Gladitz <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:gladitz@sci-vis.de" target="_blank">gladitz@sci-vis.de</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div>Hey Jean-Christophe,<br>
<br>
I currently use CMake 2.8.11-rc3 with the Ninja
generator on windows.<span class="HOEnZb"><font
color="#888888"><br>
<br>
Nils</font></span>
<div>
<div class="h5"><br>
<br>
On <a moz-do-not-send="true"
href="tel:25.04.2013%2017" value="+12504201317"
target="_blank">25.04.2013 17</a>:30,
Jean-Christophe Fillion-Robin wrote:<br>
</div>
</div>
</div>
<div>
<div class="h5">
<blockquote type="cite">
<div dir="ltr">Hi Nils,
<div><br>
</div>
<div>Since CTEST_USE_LAUNCHERS is ignored when
used with generator different from "Make" or
"Ninja" [1], it seems strange that it impacts
your windows build. Which generator are you
using ? </div>
<div><br>
</div>
<div>Hth</div>
<div>Jc</div>
<div><br>
</div>
<div>[1] <a moz-do-not-send="true"
href="https://github.com/Kitware/CMake/blob/master/Modules/CTestUseLaunchers.cmake#L38-40"
target="_blank">https://github.com/Kitware/CMake/blob/master/Modules/CTestUseLaunchers.cmake#L38-40</a></div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Thu, Apr 25, 2013 at
4:44 AM, Nils Gladitz <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:gladitz@sci-vis.de"
target="_blank">gladitz@sci-vis.de</a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="margin:0 0 0 .8ex;border-left:1px
#ccc solid;padding-left:1ex">One list entry
in my CTEST_CUSTOM_ERROR_MATCH is "FAILED: "
(in my <a moz-do-not-send="true"
href="http://CTestCustom.cmake.in"
target="_blank">CTestCustom.cmake.in</a>
which is used to generate CTestCustom.cmake
in the build directory).<br>
<br>
With CTEST_USE_LAUNCHERS enabled this does
not seem to match errors from custom
commands e.g.:<br>
"FAILED: cmd.exe /c " [...]<br>
<br>
On my CDash installation I see 0 build
errors.<br>
<br>
When I disable CTEST_USE_LAUNCHERS the error
shows up on the dashboard and the "FAILED: "
line is highlighted indicating that a match
has been made.<br>
<br>
Is this by design (e.g. not implemented for
launchers) or may I be missing something?<br>
Is there e.g. extra work required for
CTEST_CUSTOM_ERROR_MATCH to reach the
launcher?<br>
<br>
Nils<br>
<br>
-- <br>
Nils Gladitz, B.Sc.<br>
DICOM, Konnektivität und Entwicklung<br>
<br>
Scivis wissenschaftliche Bildverarbeitung
GmbH<br>
Bertha-von-Suttner-Str. 5<br>
D-37085 Göttingen<br>
GERMANY<br>
Handelsregister Nr. / Trade Register No.
B3100 Göttingen<br>
Geschäftsführer / Managing Directors Dr.
Gernot Ebel, Dr. Uwe Engeland<br>
<br>
Tel: 0049 (0)551 634181-28<br>
E-Mail: <a moz-do-not-send="true"
href="mailto:gladitz@scivis.de"
target="_blank">gladitz@scivis.de</a><br>
Web: <a moz-do-not-send="true"
href="http://www.scivis.de"
target="_blank">www.scivis.de</a><br>
<br>
--<br>
<br>
Powered by <a moz-do-not-send="true"
href="http://www.kitware.com"
target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at
<a moz-do-not-send="true"
href="http://www.kitware.com/opensource/opensource.html"
target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the
CMake FAQ at: <a moz-do-not-send="true"
href="http://www.cmake.org/Wiki/CMake_FAQ"
target="_blank">http://www.cmake.org/Wiki/CMake_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a moz-do-not-send="true"
href="http://www.cmake.org/mailman/listinfo/cmake"
target="_blank">http://www.cmake.org/mailman/listinfo/cmake</a><br>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
<a moz-do-not-send="true"
href="tel:%2B1%20919%20869%208849"
value="+19198698849" target="_blank">+1 919
869 8849</a><br>
</div>
</blockquote>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
+1 919 869 8849<br>
</div>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">--
Powered by <a class="moz-txt-link-abbreviated" href="http://www.kitware.com">www.kitware.com</a>
Visit other Kitware open-source projects at <a class="moz-txt-link-freetext" href="http://www.kitware.com/opensource/opensource.html">http://www.kitware.com/opensource/opensource.html</a>
Please keep messages on-topic and check the CMake FAQ at: <a class="moz-txt-link-freetext" href="http://www.cmake.org/Wiki/CMake_FAQ">http://www.cmake.org/Wiki/CMake_FAQ</a>
Follow this link to subscribe/unsubscribe:
<a class="moz-txt-link-freetext" href="http://www.cmake.org/mailman/listinfo/cmake">http://www.cmake.org/mailman/listinfo/cmake</a></pre>
</blockquote>
<br>
</body>
</html>