View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0011304CMakeCMakepublic2010-10-09 19:442016-06-10 14:31
ReporterCampbell Barton 
Assigned ToKitware Robot 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionmoved 
PlatformOSOS Version
Product VersionCMake-2-8 
Target VersionFixed in Version 
Summary0011304: Makefiles ignores CMAKE_RULE_MESSAGES / RULE_MESSAGES
DescriptionThe progress report's and the build target messages for cmake makefiles ignore RULE_MESSAGES.

I looked into the source and
  Source/cmGlobalUnixMakefileGenerator3.cxx, WriteProgressVariables()
is missing the check present in
  Source/cmMakefileTargetGenerator.cxx, AppendProgress()
Additional InformationLatest CMake as of today, commit 8af6a137285c091d16bb3d579f329dc259f42409
TagsNo tags attached.
Attached Filesdiff file icon make_progress.diff [^] (9,497 bytes) 2010-10-28 11:13 [Show Content]
patch file icon 0009-Honor-RULE_MESSAGES-property-properly.patch [^] (2,577 bytes) 2011-06-16 14:52 [Show Content]
diff file icon 0009-Honor-RULE_MESSAGES-property-properly-2.diff [^] (2,676 bytes) 2011-06-17 12:54 [Show Content]
patch file icon 0001-ndle-RULE_MESSAGES-property-next-try.patch [^] (3,036 bytes) 2011-06-17 13:59 [Show Content]

 Relationships
related to 0012190closedBrad King Setting RULE_MESSAGES property to OFF breaks dependencies 
related to 0012283closedBrad King Cmake -E echo kills performance of MinGW Makefiles 

  Notes
(0022470)
Brad King (manager)
2010-10-11 08:26

The RULE_MESSAGES feature includes this in its documentation:

"This is intended to allow scripted builds to avoid the build time cost of detailed reports."

The per-target messages hardly contribute to build time. We never intended them to be removed by this feature. I'm not opposed to it though.

If you really want this please attach a proposed patch.
(0022734)
Campbell Barton (reporter)
2010-10-28 11:14

attached a patch 'make_progress.diff' as suggested.
(0022816)
Brad King (manager)
2010-11-03 10:31

Looks good, thanks:

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=dc36b349 [^]
(0026510)
Brad King (manager)
2011-05-16 11:32

This patch caused a regression as reported in 0012190 so I reverted it:

  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=051cee00 [^]
(0026511)
Brad King (manager)
2011-05-16 11:33

Sending to backlog until an improved patch is available.
(0026881)
Jérôme Gardou (reporter)
2011-06-16 14:53
edited on: 2011-06-16 14:53

This latest patch should do it. At least for me :-)

This is against cmake 2.8.5 rc2 source code

(0026886)
Brad King (manager)
2011-06-16 15:59

This is "related" to 0012283 only in the sense that both are interested in faster make times and the overhead of status messages, especially when there is nothing to do.
(0026887)
Brad King (manager)
2011-06-16 16:01

Re 0011304:0026881: From reading the code change this appears to stop the progress messages. What about the "Built target XYZ" messages? There are also other places that add code for the progress that should be suppressed too.

BTW, I've not been able to apply either the patch for this issue or 0012283 cleanly. You seem to have converted spaces to tabs even in the surrounding context of the changes.
(0026902)
Jérôme Gardou (reporter)
2011-06-17 12:54
edited on: 2011-06-17 14:00

Yeah, I used Visual studio to reformat the code, and it used tabs instead of spaces :-/

The second one should make it.

EDIT : I've just seen that I forgot some things in my git commit. This latest patch should do it, with fine space this time. Sorry for the flood :-/

(0026913)
Brad King (manager)
2011-06-20 09:03

Re 0011304:0026902: A few comments on 0001-ndle-RULE_MESSAGES-property-next-try.patch:

- I still cannot apply the patch automatically. Try using a Git clone with local commits and "git format-patch origin/master.." to create patches.

- The cmGlobalGenerator is too high in the hierarchy for this. The RULE_MESSAGES property is defined only for Makefile generators. The code for it should be in cmGlobalUnixMakefileGenerator3.

- The SetCMakeInstance method is too early to compute NoRuleMessages. It needs to be in the ::Generate() method.

The original commit dc36b349 modified the proper files and looked up RULE_MESSAGES at the right time but the logic after that was not quite right.
(0041752)
Kitware Robot (administrator)
2016-06-10 14:28

Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.

 Issue History
Date Modified Username Field Change
2010-10-09 19:44 Campbell Barton New Issue
2010-10-09 23:13 Bill Hoffman Status new => assigned
2010-10-09 23:13 Bill Hoffman Assigned To => Brad King
2010-10-11 08:26 Brad King Note Added: 0022470
2010-10-28 11:13 Campbell Barton File Added: make_progress.diff
2010-10-28 11:14 Campbell Barton Note Added: 0022734
2010-11-03 10:31 Brad King Note Added: 0022816
2010-11-03 10:31 Brad King Status assigned => closed
2010-11-03 10:31 Brad King Resolution open => fixed
2011-05-16 11:32 Brad King Note Added: 0026510
2011-05-16 11:32 Brad King Status closed => feedback
2011-05-16 11:32 Brad King Resolution fixed => reopened
2011-05-16 11:33 Brad King Note Added: 0026511
2011-05-16 11:33 Brad King Assigned To Brad King =>
2011-05-16 11:33 Brad King Status feedback => backlog
2011-05-16 11:34 Brad King Relationship added related to 0012190
2011-06-16 14:52 Jérôme Gardou File Added: 0009-Honor-RULE_MESSAGES-property-properly.patch
2011-06-16 14:53 Jérôme Gardou Note Added: 0026881
2011-06-16 14:53 Jérôme Gardou Note Edited: 0026881
2011-06-16 15:58 Brad King Relationship added related to 0012283
2011-06-16 15:59 Brad King Note Added: 0026886
2011-06-16 16:01 Brad King Note Added: 0026887
2011-06-17 12:54 Jérôme Gardou File Added: 0009-Honor-RULE_MESSAGES-property-properly-2.diff
2011-06-17 12:54 Jérôme Gardou Note Added: 0026902
2011-06-17 12:55 Jérôme Gardou Note Edited: 0026902
2011-06-17 13:59 Jérôme Gardou File Added: 0001-ndle-RULE_MESSAGES-property-next-try.patch
2011-06-17 14:00 Jérôme Gardou Note Edited: 0026902
2011-06-20 09:03 Brad King Note Added: 0026913
2016-06-10 14:28 Kitware Robot Note Added: 0041752
2016-06-10 14:28 Kitware Robot Status backlog => resolved
2016-06-10 14:28 Kitware Robot Resolution reopened => moved
2016-06-10 14:28 Kitware Robot Assigned To => Kitware Robot
2016-06-10 14:31 Kitware Robot Status resolved => closed


Copyright © 2000 - 2018 MantisBT Team