View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0011429

CMake

Modules

public

2010-11-09 18:22

2011-03-10 14:41

Reporter

Vincent Levesque

Assigned To

Philip Lowman

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

CMake 2.8.3

Target Version

CMake 2.8.4

Fixed in Version

CMake 2.8.4

Summary

0011429: FindGTK2 does not find libraries built for Visual Studio 2010

Description

The version of FindGTK2.cmake included in CMake 2.8.3 looks for libraries ending in "-vc80" and "-vc90" when generating projects for Visual Studio 2008 and 2009 but does not look for "-vc100" when generating projects for Visual Studio 2010. I tested the following correction (also attached as a patch) on Windows 7 with Visual Studio 2010, CMake 2.8.3 and GTK 2.22.0:

    if(_expand_vc)
        # Add vc80/vc90/vc100 midfixes
        if(MSVC80)
            set(_library ${_library}-vc80)
            set(_library_d ${_library}-d)
        elseif(MSVC90)
            set(_library ${_library}-vc90)
            set(_library_d ${_library}-d)
    elseif(MSVC10)
            set(_library ${_library}-vc100)
            set(_library_d ${_library}-d)
        endif()
    endif()

GTK: ftp://ftp.gnome.org/pub/GNOME/binaries/win32/gtkmm/2.22/gtkmm-win32-devel-2.22.0-1.exe [^]

Tags

No tags attached.

Attached Files

findgtk2-vc100.patch [^] (382 bytes) 2010-11-09 18:22 [Show Content] [Hide Content]

diff  C:/Program Files (x86)/CMake 2.8/share/cmake-2.8/Modules/FindGTK2-2_8_3.cmake C:/Program Files (x86)/CMake 2.8/share/cmake-2.8/Modules/FindGTK2.cmake
241c241
<         # Add vc80/vc90 midfixes
---
>         # Add vc80/vc90/vc100 midfixes
246a247,249
>             set(_library_d ${_library}-d)
>         elseif(MSVC10)
>             set(_library   ${_library}-vc100)

Relationships

Notes
(0023116) Philip Lowman (developer) 2010-11-09 21:53	Thanks for the patch. I have merged it to next (with a couple of additional tweaks I made) and it should be in git master within one week. It will be in CMake 2.8.4. http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1321eb979671bb99f4d5c973e633f760fb2e3923 [^]

(0025734) David Cole (manager) 2011-03-10 14:41	Closing resolved issues that have not been updated in more than 3 months.

Issue History
Date Modified	Username	Field	Change
2010-11-09 18:22	Vincent Levesque	New Issue
2010-11-09 18:22	Vincent Levesque	File Added: findgtk2-vc100.patch
2010-11-09 21:13	Philip Lowman	Status	new => assigned
2010-11-09 21:13	Philip Lowman	Assigned To	=> Philip Lowman
2010-11-09 21:47	Philip Lowman	Target Version	=> CMake 2.8.4
2010-11-09 21:53	Philip Lowman	Note Added: 0023116
2010-11-09 21:53	Philip Lowman	Status	assigned => resolved
2010-11-09 21:53	Philip Lowman	Fixed in Version	=> CMake 2.8.4
2010-11-09 21:53	Philip Lowman	Resolution	open => fixed
2011-03-10 14:41	David Cole	Note Added: 0025734
2011-03-10 14:41	David Cole	Status	resolved => closed