View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0012440CMake(No Category)public2011-09-01 16:082012-02-06 06:07
ReporterThomas Jarosch 
Assigned ToBrad King 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake 2.8.5 
Target VersionFixed in Version 
Summary0012440: Fix various issues detected by cppcheck
DescriptionHi there,

I've given cmake a "cppcheck" lint run and
fixed various issues. Please consider the attached patches.
TagsNo tags attached.
Attached Filespatch file icon 0001-Fix-memory-leak-on-error.patch [^] (2,092 bytes) 2011-09-01 16:08 [Show Content]
patch file icon 0002-Fix-file-descriptor-leak-on-error.patch [^] (1,048 bytes) 2011-09-01 16:08 [Show Content]
patch file icon 0003-Fix-off-by-one-memory-access-error.patch [^] (887 bytes) 2011-09-01 16:08 [Show Content]

 Relationships

  Notes
(0027320)
Brad King (manager)
2011-09-02 11:17

Thanks. I've applied the patch series locally for testing.
(0027321)
Brad King (manager)
2011-09-02 11:21

Applied, thanks!

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f47393c6 [^]
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4868921b [^]
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d1751fbf [^]
(0028488)
David Cole (manager)
2012-02-06 06:07

Closing resolved issues that have not been updated in more than 4 months.

 Issue History
Date Modified Username Field Change
2011-09-01 16:08 Thomas Jarosch New Issue
2011-09-01 16:08 Thomas Jarosch File Added: 0001-Fix-memory-leak-on-error.patch
2011-09-01 16:08 Thomas Jarosch File Added: 0002-Fix-file-descriptor-leak-on-error.patch
2011-09-01 16:08 Thomas Jarosch File Added: 0003-Fix-off-by-one-memory-access-error.patch
2011-09-02 11:17 Brad King Assigned To => Brad King
2011-09-02 11:17 Brad King Status new => assigned
2011-09-02 11:17 Brad King Note Added: 0027320
2011-09-02 11:21 Brad King Note Added: 0027321
2011-09-02 11:21 Brad King Status assigned => resolved
2011-09-02 11:21 Brad King Resolution open => fixed
2012-02-06 06:07 David Cole Note Added: 0028488
2012-02-06 06:07 David Cole Status resolved => closed


Copyright © 2000 - 2018 MantisBT Team