View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0013611 | CMake | CMake | public | 2012-10-27 05:28 | 2013-04-17 08:54 | ||||
Reporter | tzeH | ||||||||
Assigned To | David Cole | ||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | |||||||||
Target Version | CMake 2.8.11 | Fixed in Version | CMake 2.8.11 | ||||||
Summary | 0013611: SOURCE_GROUP doesn't use last match | ||||||||
Description | I use a main CMake file and an include with source_group commands. Using the SOURCE_GROUP commands like this: SOURCE_GROUP( Tests\\Project REGULAR_EXPRESSION tests/Project/.* ) SOURCE_GROUP( Tests\\Project\\GUI REGULAR_EXPRESSION tests/Project/GUI/.* ) SOURCE_GROUP( Tests\\Project\\DSP REGULAR_EXPRESSION tests/Project/DSP/.* ) SOURCE_GROUP( Tests\\Project\\math REGULAR_EXPRESSION tests/Project/math/.* ) does not create three sub-folders as it should according to the documentation: "If no group explicitly lists the file, the LAST group whose regular expression matches the file will be favored." | ||||||||
Additional Information | Removing the first entry gives me three subfolders, but I want the files in tests/Project to be in a folder and not in "Source Files". I found this with the Visual Studio 2010 generators. | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | 0001-Source_groups-needed-to-check-their-own-regex-after-.patch [^] (1,075 bytes) 2012-10-28 04:56 [Show Content] | ||||||||
Relationships | |||||||||||
|
Relationships |
Notes | |
(0031346) David Cole (manager) 2012-10-27 08:53 |
Searching for SOURCE_GROUP in the bug database, I see 26 other bugs that are related to SOURCE_GROUP... I think one of them probably already reports a problem substantially similar/related to this one, but no CMake developers have given the SOURCE_GROUP problems attention yet. If you can attach a "git format-patch -1" file to fix the problem, we'll consider it. Thx |
(0031348) tzeH (reporter) 2012-10-28 04:58 edited on: 2012-10-28 04:59 |
Hi David, I attached a fix for this problem that works for me. The problem was, that cmSourceGroup::MatchChildrenRegex checked it's own regex before trying it's children's. This should also fix 0004395 and 0008711 (of which this is a duplicate). |
(0031682) David Cole (manager) 2012-11-23 11:28 |
Fix pushed and merged to CMake 'next' branch: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=00e96808aa3729a6b385818643249ea2130cbef1 [^] |
(0031683) David Cole (manager) 2012-11-23 11:28 |
I verified (manually) that the fix works with Visual Studio 10 and Xcode generators. |
(0032878) Robert Maynard (manager) 2013-04-17 08:54 |
Closing resolved issues that have not been updated in more than 4 months. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2012-10-27 05:28 | tzeH | New Issue | |
2012-10-27 08:53 | David Cole | Note Added: 0031346 | |
2012-10-28 04:56 | tzeH | File Added: 0001-Source_groups-needed-to-check-their-own-regex-after-.patch | |
2012-10-28 04:58 | tzeH | Note Added: 0031348 | |
2012-10-28 04:59 | tzeH | Note Edited: 0031348 | |
2012-10-28 09:16 | David Cole | Assigned To | => David Cole |
2012-10-28 09:16 | David Cole | Status | new => assigned |
2012-10-28 09:16 | David Cole | Target Version | => CMake 2.8.11 |
2012-10-28 09:22 | David Cole | Relationship added | related to 0004395 |
2012-10-28 09:22 | David Cole | Relationship added | related to 0008711 |
2012-11-23 11:28 | David Cole | Note Added: 0031682 | |
2012-11-23 11:28 | David Cole | Status | assigned => resolved |
2012-11-23 11:28 | David Cole | Fixed in Version | => CMake 2.8.11 |
2012-11-23 11:28 | David Cole | Resolution | open => fixed |
2012-11-23 11:28 | David Cole | Note Added: 0031683 | |
2013-04-17 08:54 | Robert Maynard | Note Added: 0032878 | |
2013-04-17 08:54 | Robert Maynard | Status | resolved => closed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |