View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0014043

CMake

public

2013-03-27 06:15

2013-10-07 10:09

Reporter

Mathias Gaunard

Assigned To

Robert Maynard

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

x86_64

Linux

OS Version

Product Version

CMake 2.8.10

Target Version

Fixed in Version

CMake 2.8.12

Summary

0014043: CUDA_COMPUTE_BUILD_PATH unnecessarily generates very long path when source is in binary directory

Description

I generate .cu files in the binary directory that I then build with CUDA_ADD_EXECUTABLE. Unfortunately CUDA_COMPUTE_BUILD_PATH will generate a path for intermediate files based on the relative path of that .cu file to the source directory; this may cause very long paths in the resulting building rules.

In particular it prevents building with Ninja on Linux.

Patch to fix this problem is attached: it makes the path relative to the current binary directory if the file is in the current binary directory.

Tags

No tags attached.

Attached Files

cuda_source_in_binary_path.diff [^] (665 bytes) 2013-03-27 06:15 [Show Content] [Hide Content]

diff --git a/Modules/FindCUDA.cmake b/Modules/FindCUDA.cmake
index 423ad3d..cc8e926 100644
--- a/Modules/FindCUDA.cmake
+++ b/Modules/FindCUDA.cmake
@@ -920,6 +920,11 @@ function(CUDA_COMPUTE_BUILD_PATH path build_path)
   if (IS_ABSOLUTE "${bpath}")
     # Absolute paths are generally unnessary, especially if something like
     # file(GLOB_RECURSE) is used to pick up the files.
+
+    string(FIND "${bpath}" "${CMAKE_CURRENT_BINARY_DIR}" _binary_dir_pos)
+    if (_binary_dir_pos EQUAL 0)
+      file(RELATIVE_PATH bpath "${CMAKE_CURRENT_BINARY_DIR}" "${bpath}")
+    else()
     file(RELATIVE_PATH bpath "${CMAKE_CURRENT_SOURCE_DIR}" "${bpath}")
   endif()

cuda_source_in_binary_path_fixed.diff [^] (834 bytes) 2013-03-27 06:36 [Show Content] [Hide Content]

diff --git a/Modules/FindCUDA.cmake b/Modules/FindCUDA.cmake
index 423ad3d..8248624 100644
--- a/Modules/FindCUDA.cmake
+++ b/Modules/FindCUDA.cmake
@@ -920,7 +920,13 @@ function(CUDA_COMPUTE_BUILD_PATH path build_path)
   if (IS_ABSOLUTE "${bpath}")
     # Absolute paths are generally unnessary, especially if something like
     # file(GLOB_RECURSE) is used to pick up the files.
-    file(RELATIVE_PATH bpath "${CMAKE_CURRENT_SOURCE_DIR}" "${bpath}")
+
+    string(FIND "${bpath}" "${CMAKE_CURRENT_BINARY_DIR}" _binary_dir_pos)
+    if (_binary_dir_pos EQUAL 0)
+      file(RELATIVE_PATH bpath "${CMAKE_CURRENT_BINARY_DIR}" "${bpath}")
+    else()
+      file(RELATIVE_PATH bpath "${CMAKE_CURRENT_SOURCE_DIR}" "${bpath}")
+    endif()
   endif()
 
   # This recipie is from cmLocalGenerator::CreateSafeUniqueObjectFileName in the

Relationships

Notes
(0032704) Mathias Gaunard (reporter) 2013-03-27 06:37	Wrong diff in first file, please delete. Change also available as a pull request on github: https://github.com/Kitware/CMake/pull/39 [^]

(0034059) Robert Maynard (manager) 2013-10-07 10:09	Closing resolved issues that have not been updated in more than 4 months.

Issue History
Date Modified	Username	Field	Change
2013-03-27 06:15	Mathias Gaunard	New Issue
2013-03-27 06:15	Mathias Gaunard	File Added: cuda_source_in_binary_path.diff
2013-03-27 06:36	Mathias Gaunard	File Added: cuda_source_in_binary_path_fixed.diff
2013-03-27 06:37	Mathias Gaunard	Note Added: 0032704
2013-03-27 08:29	Robert Maynard	Assigned To	=> Robert Maynard
2013-03-27 08:29	Robert Maynard	Status	new => assigned
2013-04-18 14:20	Robert Maynard	Status	assigned => acknowledged
2013-05-24 09:36	Robert Maynard	Status	acknowledged => resolved
2013-05-24 09:36	Robert Maynard	Fixed in Version	=> CMake 2.8.12
2013-05-24 09:36	Robert Maynard	Resolution	open => fixed
2013-10-07 10:09	Robert Maynard	Note Added: 0034059
2013-10-07 10:09	Robert Maynard	Status	resolved => closed