View Issue Details [ Jump to Notes ] | [ Print ] |
ID | Project | Category | View Status | Date Submitted | Last Update |
0014112 | CMake | CPack | public | 2013-04-26 10:51 | 2016-06-10 14:31 |
|
Reporter | David Golub | |
Assigned To | Kitware Robot | |
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | moved | |
Platform | Microsoft | OS | Windows | OS Version | 7 |
Product Version | CMake 2.8.10.2 | |
Target Version | | Fixed in Version | | |
|
Summary | 0014112: NSIS installer shows new version's display name in prompt to uninstall |
Description | When CPACK_NSIS_ENABLE_UNINSTALL_BEFORE_INSTALL is set, the installer checks for a previously installed version. If it detects one, it displays a prompt to uninstall that reads "X is already installed." However, X is the display name for the new version that is about to be installed, not for the old version that is already installed. This is bound to confuse users. I'm submitting a patch to read the display name for the old version from the registry and display it in the message box. |
Tags | No tags attached. |
|
Attached Files | 0001-CPack-NSIS-Use-display-name-of-installed-version-in-.patch [^] (1,152 bytes) 2013-04-26 10:51 [Show Content] [Hide Content]From dcf35d143ca10b20911d91377037a893fa7490e0 Mon Sep 17 00:00:00 2001
From: David Golub <golubdr@gmail.com>
Date: Fri, 26 Apr 2013 10:44:03 -0400
Subject: [PATCH] CPack/NSIS: Use display name of installed version in prompt
to uninstall
---
Modules/NSIS.template.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Modules/NSIS.template.in b/Modules/NSIS.template.in
index 59a444b..acc72ff 100644
--- a/Modules/NSIS.template.in
+++ b/Modules/NSIS.template.in
@@ -908,8 +908,9 @@ Function .onInit
ReadRegStr $0 HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\@CPACK_PACKAGE_INSTALL_REGISTRY_KEY@" "UninstallString"
StrCmp $0 "" inst
+ ReadRegStr $1 HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\@CPACK_PACKAGE_INSTALL_REGISTRY_KEY@" "DisplayName"
MessageBox MB_YESNOCANCEL|MB_ICONEXCLAMATION \
- "@CPACK_NSIS_PACKAGE_NAME@ is already installed. $\n$\nDo you want to uninstall the old version before installing the new one?" \
+ "$1 is already installed. $\n$\nDo you want to uninstall the old version before installing the new one?" \
IDYES uninst IDNO inst
Abort
--
1.8.1.msysgit.1
|
|