View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0014127 | CMake | CMake | public | 2013-05-05 17:14 | 2016-06-10 14:31 | ||||
Reporter | Andreas Mohr | ||||||||
Assigned To | Brad King | ||||||||
Priority | high | Severity | minor | Reproducibility | N/A | ||||
Status | closed | Resolution | moved | ||||||
Platform | PC | OS | Linux | OS Version | Debian | ||||
Product Version | CMake 2.8.10.2 | ||||||||
Target Version | Fixed in Version | ||||||||
Summary | 0014127: [PATCH] Patchset git master: several documentation improvements/corrections, typos, bug fixes | ||||||||
Description | For standard blurb, see prior submission (0013659). Contains patches: 0001-Typos-spelling-important-affecting-users.patch 0002-Typos-spelling-affecting-binary-data-module-messages.patch 0003-Typos-spelling-non-binary.patch 0004-FindwxWidgets.cmake-add-DOC-strings-use-usual-style.patch 0005-Explain-distribution-of-Win9x-binary-on-all-Windows-.patch 0006-VS10-generator-add-detailed-comment-about-MIDL-proce.patch 0007-Fix-improperly-updated-copy-paste-part-warning-error.patch 0008-Docs-have-central-info-for-Check-modules-and-point-t.patch 0009-Docs-misc.-improvements.patch 0010-Docs-fix-description-of-CMAKE_BUILD_TYPE-CMAKE_CONFI.patch 0011-Docs-add-filename.patch 0012-Docs-FOO-used-FOO-to-be-used-FOO-will-be-used.patch 0013-Spelling-correct-product-names-no-debate.patch 0014-Spelling-correct-product-names-debatable-Mac-OSX-Mac.patch After my recent tirade, I figured that a new CMake patch submission was in order ;) I'm totally not certain whether all of these should be applied, or how. So, IOW, RFC, comments wanted. Yeah, reading through all the repository's text content to determine which corrections to make indeed was boring (17000 lines?), but I was very astonished to see that I had ended up emailing me some 20 mails with very interesting new CMake info gathered through that... (--> "you should try that yourself sometime" ;) Thanks! | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | ![]() | ||||||||
Relationships | |
Relationships |
Notes | |
(0032997) Brad King (manager) 2013-05-06 10:44 |
Thanks. I've extracted the Source/kwsys changes and sent them to KWSys upstream: http://review.source.kitware.com/#/c/11150/ [^] After that goes in I'll merge it to CMake and rebase the rest of this series on it. |
(0033021) Brad King (manager) 2013-05-10 08:37 |
Re 0014127:0032997: The KWSys changes have been imported back to CMake here: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d0cdc687 [^] |
(0033022) Brad King (manager) 2013-05-10 08:38 |
I've applied most of the patches with minor tweaks: Fix spelling and typos (affecting users) http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=86832cec [^] Fix spelling and typos (affecting binary data / module messages) http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ddac8d3d [^] Fix spelling and typos (non-binary) http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bf019d76 [^] Fix spelling and typos (product names) http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f57800d6 [^] FindwxWidgets: add DOC strings with usual style http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5ca4336e [^] Explain distribution of Win9x binary on all Windows versions. http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e619111d [^] VS10: add detailed comment about MIDL processing http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2bab472e [^] Docs: Update description of CMAKE_(BUILD_TYPE|CONFIGURATION_TYPES) http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=56ca34db [^] Docs: Clarify that CMAKE_*_(PREFIX|SUFFIX) affect filenames http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2378a698 [^] Docs: Clarify wording "flag used" => "flag (to|will) be used" http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7cc2805c [^] |
(0033023) Brad King (manager) 2013-05-10 08:42 |
The two patches I've not yet applied are: * "Docs: misc. improvements." -- Please split this up into separate commits for individual review. * "Docs: have central info for Check* modules" -- I don't like centralizing on a specific check module. It gives the appearance of a relationship between the modules that does not exist. In the future CMake may have better support for cross-references and generic document sections, but for now I think it is simplest to just duplicate information like +# Since the result of the check gets stored in a persistent CACHE variable, +# subsequently removing this variable from cache again is required +# if one needs the check to re-execute. in each affected module. Lots of other documentation is already duplicated similarly across those modules. |
(0033024) Andreas Mohr (reporter) 2013-05-10 10:00 |
Thank you for the really quick processing! I'm ok with Check*. Have to say that "misc. improvements *was* split originally. Will rebase on master, then submit these (here) as requested, thanks! |
(0042274) Kitware Robot (administrator) 2016-06-10 14:28 |
Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2013-05-05 17:14 | Andreas Mohr | New Issue | |
2013-05-05 17:14 | Andreas Mohr | File Added: git_cmake_master_format_patch_set_20130505.tar.gz | |
2013-05-06 10:44 | Brad King | Note Added: 0032997 | |
2013-05-06 10:44 | Brad King | Assigned To | => Brad King |
2013-05-06 10:44 | Brad King | Status | new => assigned |
2013-05-10 08:37 | Brad King | Note Added: 0033021 | |
2013-05-10 08:38 | Brad King | Note Added: 0033022 | |
2013-05-10 08:42 | Brad King | Note Added: 0033023 | |
2013-05-10 10:00 | Andreas Mohr | Note Added: 0033024 | |
2016-06-10 14:28 | Kitware Robot | Note Added: 0042274 | |
2016-06-10 14:28 | Kitware Robot | Status | assigned => resolved |
2016-06-10 14:28 | Kitware Robot | Resolution | open => moved |
2016-06-10 14:31 | Kitware Robot | Status | resolved => closed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |