(0033870)
Eric NOULARD (developer)
2013-09-24 08:25

Yes you are right however it may be easier to use
CPACK_WIX_TEMPLATE
because you don't need to know that such template files are searched
using CMAKE_MODULE_PATH.

And frankly thinking that you may tweak CMAKE_MODULE_PATH for changing
template file is quite awkward.

So I would keep this "redundant" feature.
I would even be tempted to create CPACK_NSIS_TEMPLATE etc...
because it's easier to find your way by getting the list
of possible

CPACK_xxx / CPACK_NSIS_xxx variables than understanding that any template
is searched using CMAKE_MODULE_PATH.

My personal opinion though.

(0033871)
Nils Gladitz (developer)
2013-09-24 08:27

I thought so as well and adopted the behaviour as such from the NSIS generator.

In hindsight I don't mind the addition of CPACK_WIX_TEMPLATE though since it may be easier to find and use for cmake users who aren't familiar with those internals.

(0033885)
Domagoj Saric (reporter)
2013-09-25 06:20

Hm..ok..but at the very least documentation should be updated to reflect this (for example I was under the impression that the "CMAKE_MODULE_PATH way" was the prescribed, not an "internal", way of doing this).
In addition, this issue harks back to 0014433, i.e. if the explicit CPACK_*_TEMPLATE approach is going to be standard it should be "unified"/standardized and supported across generators (e.g. Package Maker...)

(0034111)
Nils Gladitz (developer)
2013-10-13 03:15

Neither the "CMAKE_MODULE_PATH way" nor the existence of the NSIS template are documented officially in the manual as far as I can see.

CPACK_WIX_TEMPLATE is documented now so at least from the WiX side of things there should be no further changes required.

(0035279)
Robert Maynard (manager)
2014-03-05 09:58

Closing resolved issues that have not been updated in more than 4 months

Issue History
Date Modified	Username	Field	Change
2013-09-24 08:10	Domagoj Saric	New Issue
2013-09-24 08:25	Eric NOULARD	Note Added: 0033870
2013-09-24 08:27	Nils Gladitz	Note Added: 0033871
2013-09-25 06:20	Domagoj Saric	Note Added: 0033885
2013-10-12 17:12	Nils Gladitz	Status	new => assigned
2013-10-12 17:12	Nils Gladitz	Assigned To	=> Nils Gladitz
2013-10-13 03:15	Nils Gladitz	Note Added: 0034111
2013-10-13 03:15	Nils Gladitz	Status	assigned => resolved
2013-10-13 03:15	Nils Gladitz	Resolution	open => no change required
2014-03-05 09:58	Robert Maynard	Note Added: 0035279
2014-03-05 09:58	Robert Maynard	Status	resolved => closed

Notes
(0033870) Eric NOULARD (developer) 2013-09-24 08:25	Yes you are right however it may be easier to use CPACK_WIX_TEMPLATE because you don't need to know that such template files are searched using CMAKE_MODULE_PATH. And frankly thinking that you may tweak CMAKE_MODULE_PATH for changing template file is quite awkward. So I would keep this "redundant" feature. I would even be tempted to create CPACK_NSIS_TEMPLATE etc... because it's easier to find your way by getting the list of possible CPACK_xxx / CPACK_NSIS_xxx variables than understanding that any template is searched using CMAKE_MODULE_PATH. My personal opinion though.

(0033871) Nils Gladitz (developer) 2013-09-24 08:27	I thought so as well and adopted the behaviour as such from the NSIS generator. In hindsight I don't mind the addition of CPACK_WIX_TEMPLATE though since it may be easier to find and use for cmake users who aren't familiar with those internals.

(0033885) Domagoj Saric (reporter) 2013-09-25 06:20	Hm..ok..but at the very least documentation should be updated to reflect this (for example I was under the impression that the "CMAKE_MODULE_PATH way" was the prescribed, not an "internal", way of doing this). In addition, this issue harks back to 0014433, i.e. if the explicit CPACK_*_TEMPLATE approach is going to be standard it should be "unified"/standardized and supported across generators (e.g. Package Maker...)

(0034111) Nils Gladitz (developer) 2013-10-13 03:15	Neither the "CMAKE_MODULE_PATH way" nor the existence of the NSIS template are documented officially in the manual as far as I can see. CPACK_WIX_TEMPLATE is documented now so at least from the WiX side of things there should be no further changes required.

(0035279) Robert Maynard (manager) 2014-03-05 09:58	Closing resolved issues that have not been updated in more than 4 months

Relationships