View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014762CMakeCPackpublic2014-02-17 16:572014-10-06 10:32
ReporterDavid Golub 
Assigned ToNils Gladitz 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS Version7
Product VersionCMake 2.8.12.2 
Target VersionFixed in Version 
Summary0014762: Add support for customizing strings in Add/Remove Programs
DescriptionI'm submitting a patch to add support for customizing the various strings that appear in the Add/Remove Programs applet when packaging with Windows Installer XML.
TagsNo tags attached.
Attached Filespatch file icon 0001-CPack-WIX-Add-support-for-more-customization-of-Add-.patch [^] (4,292 bytes) 2014-02-17 16:57 [Show Content]

 Relationships

  Notes
(0035138)
Nils Gladitz (developer)
2014-02-18 03:06

Thank you for the patch.
It looks definitely like something that the WiX generator should support.

I'd like to evaluate some alternatives before merging it though.

Since the way these properties are being added seems repetitive I am wondering
if something more generic could be added which preferably would also avoid frequently updating the template.

A list of properties and values that is used to generate an extra source file might be one option.

Also it might be nice if some of these could be mapped to generic (rather than WiX specific) CPACK_ variables.

E.g. the existing CPACK_PACKAGE_CONTACT might be appropriate for ARPCONTACT?

NSIS and other generators seem to have a couple of these too which might be consolidated.

Could just be wishful thinking though since it would have to be done without breaking existing behavior of the other generators.
(0035238)
Nils Gladitz (developer)
2014-03-03 11:34

Implemented by http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=378eb5b712bb8f131e62aa343e3ec27d446dc098 [^]
(0036928)
Robert Maynard (manager)
2014-10-06 10:32

Closing resolved issues that have not been updated in more than 4 months.

 Issue History
Date Modified Username Field Change
2014-02-17 16:57 David Golub New Issue
2014-02-17 16:57 David Golub File Added: 0001-CPack-WIX-Add-support-for-more-customization-of-Add-.patch
2014-02-17 17:10 Nils Gladitz Assigned To => Nils Gladitz
2014-02-17 17:10 Nils Gladitz Status new => assigned
2014-02-18 03:06 Nils Gladitz Note Added: 0035138
2014-03-03 11:34 Nils Gladitz Note Added: 0035238
2014-03-03 11:34 Nils Gladitz Status assigned => resolved
2014-03-03 11:34 Nils Gladitz Resolution open => fixed
2014-10-06 10:32 Robert Maynard Note Added: 0036928
2014-10-06 10:32 Robert Maynard Status resolved => closed


Copyright © 2000 - 2018 MantisBT Team