View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014813CMakeCMakepublic2014-03-18 04:542014-10-06 10:33
ReporterMichał Cichoń 
Assigned ToClinton Stimpson 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformPCOSWindowsOS Version7 x64
Product Version 
Target VersionFixed in Version 
Summary0014813: find_package(Qt4 4.6.2 QUIET) isn't really quiet
Descriptionfind_package(Qt4 4.6.2 QUIET) is poluting output with messages even if it is ask to be quiet.
TagsNo tags attached.
Attached Files

 Relationships
related to 0014812closedClinton Stimpson find_package(OpenMP QUIET) isn't really quiet 

  Notes
(0035427)
Michał Cichoń (reporter)
2014-03-18 08:51

 Forgot to attach printed messages:
Looking for Q_WS_X11
Looking for Q_WS_X11 - not found
Looking for Q_WS_WIN
Looking for Q_WS_WIN - found
Looking for Q_WS_QWS
Looking for Q_WS_QWS - not found
Looking for Q_WS_MAC
Looking for Q_WS_MAC - not found
(0035544)
Clinton Stimpson (developer)
2014-03-28 00:21

 Brad, can you do a review on the stage/find_package-check-quiet topic which fixes this and bug 0014812?
(0035547)
Stephen Kelly (developer)
2014-03-28 03:34

 Clinton, in your patch, does the CMAKE_REQUIRED_QUIET setting from Find modules leak out?
(0035551)
Clinton Stimpson (developer)
2014-03-28 08:43

 It does not. To check that I did

find_package(Qt4 QUIET)
unset(Q_WS_MAC CACHE)
unset(Q_WS_X11 CACHE)
unset(Q_WS_WIN CACHE)
find_package(Qt4)

And for the 2nd find package, I got the verbose output again.
(0035552)
Clinton Stimpson (developer)
2014-03-28 08:51

 Oh, but wait... it does leak out.

unset(Q_WS_MAC CACHE)
find_package(Qt4 4.6 QUIET)

unset(Q_WS_MAC CACHE)
set(CMAKE_REQUIRED_INCLUDES "${CMAKE_REQUIRED_INCLUDES};${QT_INCLUDE_DIR}")
CHECK_CXX_SYMBOL_EXISTS(Q_WS_MAC "QtCore/qglobal.h" Q_WS_MAC)

The check_cxx_symbol_exists() was quiet when it should not have been.
Thanks for checking.
(0035554)
Stephen Kelly (developer)
2014-03-28 11:48

 I see you updated the topic to use CMakePushCheckState.

Wouldn't it be less code, and require fewer includes to simply unset the variable after use?
(0035559)
Clinton Stimpson (developer)
2014-03-28 15:04

 Yes, it would be less code.

But I wasn't sure I could assume that the caller never sets the CHECK_REQUIRED_* variables to affect the behavior of all these check modules.
(0035567)
Clinton Stimpson (developer)
2014-03-31 09:18

 http://cmake.org/gitweb?p=cmake.git;a=commit;h=83934757 [^]
(0036960)
Robert Maynard (manager)
2014-10-06 10:33

 Closing resolved issues that have not been updated in more than 4 months.

 Issue History
Date Modified Username Field Change
2014-03-18 04:54 Michał Cichoń New Issue
2014-03-18 08:40 Brad King Assigned To => Clinton Stimpson
2014-03-18 08:40 Brad King Status new => assigned
2014-03-18 08:51 Michał Cichoń Note Added: 0035427
2014-03-18 11:51 Brad King Relationship added related to 0014812
2014-03-28 00:21 Clinton Stimpson Note Added: 0035544
2014-03-28 03:34 Stephen Kelly Note Added: 0035547
2014-03-28 08:43 Clinton Stimpson Note Added: 0035551
2014-03-28 08:51 Clinton Stimpson Note Added: 0035552
2014-03-28 11:48 Stephen Kelly Note Added: 0035554
2014-03-28 15:04 Clinton Stimpson Note Added: 0035559
2014-03-31 09:18 Clinton Stimpson Note Added: 0035567
2014-03-31 09:18 Clinton Stimpson Status assigned => resolved
2014-03-31 09:18 Clinton Stimpson Resolution open => fixed
2014-10-06 10:33 Robert Maynard Note Added: 0036960
2014-10-06 10:33 Robert Maynard Status resolved => closed

Copyright © 2000 - 2018 MantisBT Team