View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0015021CMakeModulespublic2014-07-15 04:472015-01-05 08:39
ReporterJoachim Wuttke 
Assigned ToNils Gladitz 
PrioritynormalSeveritytextReproducibilityhave not tried
StatusclosedResolutionno change required 
PlatformOSOS Version
Product VersionCMake 2.8.12.1 
Target VersionFixed in Version 
Summary0015021: misleading header comments in FindHDF5
Description- Header component says module takes 'COMPONENTS' argument. Doesn't work for me; what works for me is
  set( HDF5_FIND_COMPONENTS "CXX" )
  include( FindHDF5 )

- Header comment says module will define 'HDF5_CXX_LIBRARIES'. Doesn't work for me; the module only defines 'HDF5_LIBRARIES'
  
TagsNo tags attached.
Attached Files

 Relationships

  Notes
(0036389)
Philipp Möller (reporter)
2014-07-15 05:17

 You should not use include with FindModules, but find_package(HDF5 COMPONENTS CXX). I just tried this with CMake 3.0 and it seems to work as intended. The file only has been affected by one commit since 2.8.12 which should only affect performance. It also looks like the components flag is handled correctly in the code.

Which platform are you on?
(0036390)
Nils Gladitz (developer)
2014-07-15 05:23

 Find*.cmake modules are intended for the find_package() command.

find_package(HDF5 REQUIRED COMPONENTS CXX)

implicitly sets HDF5_FIND_COMPONENTS to "CXX" while the module is being processed.

With the command as-is HDF5_CXX_LIBRARIES seems to get set to a valid list of libraries for me as well (2.8.12.2 on Ubuntu).
(0036391)
Joachim Wuttke (reporter)
2014-07-15 05:26

 Thanks! I confirm: with find_package both problems are gone.
(0036392)
Nils Gladitz (developer)
2014-07-15 05:33

 Great. I am resolving the issue with "no change required".
(0037586)
Robert Maynard (manager)
2015-01-05 08:39

 Closing resolved issues that have not been updated in more than 4 months

 Issue History
Date Modified Username Field Change
2014-07-15 04:47 Joachim Wuttke New Issue
2014-07-15 05:17 Philipp Möller Note Added: 0036389
2014-07-15 05:23 Nils Gladitz Note Added: 0036390
2014-07-15 05:26 Joachim Wuttke Note Added: 0036391
2014-07-15 05:33 Nils Gladitz Note Added: 0036392
2014-07-15 05:33 Nils Gladitz Status new => resolved
2014-07-15 05:33 Nils Gladitz Resolution open => no change required
2014-07-15 05:33 Nils Gladitz Assigned To => Nils Gladitz
2015-01-05 08:39 Robert Maynard Note Added: 0037586
2015-01-05 08:39 Robert Maynard Status resolved => closed

Copyright © 2000 - 2018 MantisBT Team