| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0015295 | CMake | CMake | public | 2014-12-09 05:30 | 2016-06-10 14:31 | ||||
| Reporter | Ilya | ||||||||
| Assigned To | Kitware Robot | ||||||||
| Priority | high | Severity | major | Reproducibility | always | ||||
| Status | closed | Resolution | moved | ||||||
| Platform | Windows | OS | OS Version | ||||||
| Product Version | |||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0015295: Ninja: CMake should not concatenate commands for cmd.exe | ||||||||
| Description | Commands like add_custom_target allows to specify many COMMAND parameters. On windows it concatenates all values into one big command and then passes to cmd.exe Unfortunately cmd.exe has limit of the length of a command that can be passed: 8192. Therefore CMake should not attempt to concatenate but pass commands to cmd.exe one by one. | ||||||||
| Tags | No tags attached. | ||||||||
| Attached Files | |||||||||
| Relationships | |
| Relationships |
| Notes | |
|
(0037423) Brad King (manager) 2014-12-09 08:13 |
Which generator are you using? |
|
(0037427) Ilya (reporter) 2014-12-09 12:34 |
Ninja |
|
(0037429) Brad King (manager) 2014-12-09 15:16 |
It looks like the current implementation is in cmLocalNinjaGenerator::BuildCommandLine: http://www.cmake.org/gitweb?p=cmake.git;a=blob;f=Source/cmLocalNinjaGenerator.cxx;hb=v3.0.2#l316 [^] The semantics CMake defines for multiple commands is that each will be run only if the preceding ones succeeded. That is what the "&&" chain does now. Any refactoring will need to preserve that. |
|
(0042683) Kitware Robot (administrator) 2016-06-10 14:29 |
Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page. |
| Notes |
| Issue History | |||
| Date Modified | Username | Field | Change |
| 2014-12-09 05:30 | Ilya | New Issue | |
| 2014-12-09 08:13 | Brad King | Note Added: 0037423 | |
| 2014-12-09 12:34 | Ilya | Note Added: 0037427 | |
| 2014-12-09 15:16 | Brad King | Note Added: 0037429 | |
| 2014-12-09 15:16 | Brad King | Status | new => acknowledged |
| 2014-12-09 15:16 | Brad King | Summary | CMake should not concatenate commands for cmd.exe => Ninja: CMake should not concatenate commands for cmd.exe |
| 2016-06-10 14:29 | Kitware Robot | Note Added: 0042683 | |
| 2016-06-10 14:29 | Kitware Robot | Status | acknowledged => resolved |
| 2016-06-10 14:29 | Kitware Robot | Resolution | open => moved |
| 2016-06-10 14:29 | Kitware Robot | Assigned To | => Kitware Robot |
| 2016-06-10 14:31 | Kitware Robot | Status | resolved => closed |
| Issue History |
| Copyright © 2000 - 2018 MantisBT Team |