| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0015296 | CMake | CMake | public | 2014-12-10 07:02 | 2016-06-10 14:31 | ||||
| Reporter | Ilya | ||||||||
| Assigned To | Kitware Robot | ||||||||
| Priority | normal | Severity | major | Reproducibility | always | ||||
| Status | closed | Resolution | moved | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | |||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0015296: External Project improperly handles updates from VCS | ||||||||
| Description | When External Project is configured to get sources from git repo from a branch it improperly handles changes. When generator is Ninja, it simply ignores changes and do not rebuild. When generator is UNIX Makefiles it always rebuilds despite whether there were changes or not. Probably this is also true for other VCS sources. | ||||||||
| Tags | ninja | ||||||||
| Attached Files | |||||||||
| Relationships | |
| Relationships |
| Notes | |
|
(0037432) Daniele E. Domenichelli (developer) 2014-12-10 07:55 |
ExternalProject has no way to know if one or more files from the external project was updated, therefore the build must run after the update step. Therefore, in my opinion, the UNIX Makefile generator is correct. I don't know much about the Ninja generator, but if it doesn't run the build step after the update step, there could be a bug. Which CMake version are you using? |
|
(0037433) Ilya (reporter) 2014-12-10 09:38 edited on: 2014-12-10 09:38 |
ExternalProject can check SHA of current and new commit to determine whether any changes were introduced. |
|
(0039830) Nicholas Braden (reporter) 2015-11-03 16:21 |
I can reproduce this issue, Windows 10 64bit using CMake 3.3.1 and Ninja 1.6.0. Ninja only builds external projects the first time. No amount of rerunning it will get it to rebuild external projects that have been updated by git. With Unix Makefiles generator or MinGW Makefiles generator, it works correctly. |
|
(0042684) Kitware Robot (administrator) 2016-06-10 14:29 |
Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page. |
| Notes |
| Issue History | |||
| Date Modified | Username | Field | Change |
| 2014-12-10 07:02 | Ilya | New Issue | |
| 2014-12-10 07:55 | Daniele E. Domenichelli | Note Added: 0037432 | |
| 2014-12-10 09:38 | Ilya | Note Added: 0037433 | |
| 2014-12-10 09:38 | Ilya | Note Edited: 0037433 | |
| 2015-11-03 16:21 | Nicholas Braden | Note Added: 0039830 | |
| 2015-11-03 16:22 | Nicholas Braden | Tag Attached: ninja | |
| 2016-06-10 14:29 | Kitware Robot | Note Added: 0042684 | |
| 2016-06-10 14:29 | Kitware Robot | Status | new => resolved |
| 2016-06-10 14:29 | Kitware Robot | Resolution | open => moved |
| 2016-06-10 14:29 | Kitware Robot | Assigned To | => Kitware Robot |
| 2016-06-10 14:31 | Kitware Robot | Status | resolved => closed |
| Issue History |
| Copyright © 2000 - 2018 MantisBT Team |