View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0015368 | CMake | CMake | public | 2015-01-23 01:18 | 2015-06-01 08:38 | ||||
Reporter | peitschie | ||||||||
Assigned To | |||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | CMake 3.1 | ||||||||
Target Version | CMake 3.2 | Fixed in Version | CMake 3.2 | ||||||
Summary | 0015368: ExternalProject's BUILD_ALWAYS flag doesn't clear any existing build stamp file | ||||||||
Description | Setting the BUILD_ALWAYS flag on an external project should cause the build step to always trigger. This was new in 3.1 from what I can see. Unfortunately, it appears to do this by making the *next* stamp file created symbolic (see https://github.com/Kitware/CMake/blob/master/Modules/ExternalProject.cmake#L1457 [^]). This means that until the existing stamp file is deleted, or something else causes a rebuild to occur, BUILD_ALWAYS has no effect | ||||||||
Steps To Reproduce | 1. Create a CMake file with an external project, with BUILD_ALWAYS set to 0 2. Build the external project 3. Change the BUILD_ALWAYS flag to 1 4. Attempt to rebuild the external project, and note how the build step is never executed. | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | 0001-ExternalProject-Allow-ALWAYS-step-property-to-be-swi.patch [^] (1,472 bytes) 2015-01-23 13:39 [Show Content] | ||||||||
Relationships | |
Relationships |
Notes | |
(0037789) Brad King (manager) 2015-01-23 13:39 |
Please try "0001-ExternalProject-Allow-ALWAYS-step-property-to-be-swi.patch". |
(0037800) peitschie (reporter) 2015-01-23 16:43 |
Thanks for the rapid response! I can confirm this fixes the issue. Thanks! |
(0037807) Brad King (manager) 2015-01-26 08:49 |
Thanks for testing. Patch applied: ExternalProject: Allow ALWAYS step property to be switched http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a4605973 [^] |
(0038857) Robert Maynard (manager) 2015-06-01 08:38 |
Closing resolved issues that have not been updated in more than 4 months. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2015-01-23 01:18 | peitschie | New Issue | |
2015-01-23 13:39 | Brad King | File Added: 0001-ExternalProject-Allow-ALWAYS-step-property-to-be-swi.patch | |
2015-01-23 13:39 | Brad King | Note Added: 0037789 | |
2015-01-23 16:43 | peitschie | Note Added: 0037800 | |
2015-01-26 08:49 | Brad King | Note Added: 0037807 | |
2015-01-26 08:49 | Brad King | Status | new => resolved |
2015-01-26 08:49 | Brad King | Resolution | open => fixed |
2015-01-26 08:49 | Brad King | Fixed in Version | => CMake 3.2 |
2015-01-26 08:49 | Brad King | Target Version | => CMake 3.2 |
2015-06-01 08:38 | Robert Maynard | Note Added: 0038857 | |
2015-06-01 08:38 | Robert Maynard | Status | resolved => closed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |