View Issue Details [ Jump to Notes ]

[ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0002771

CMake

CMake

public

2006-01-27 10:29

2006-01-27 13:09

Reporter

Filipe Sousa

Assigned To

Brad King

Priority

low

Severity

feature

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS

OS Version

Product Version

Target Version

Fixed in Version

Summary

0002771: Enhancement of FIND_PACKAGE

Description

I'm thinking we could extend REQUIRED parameter from FIND_PACKAGE to be
more specific. Some packages have a lot of libraries and we may not need
all them. Something like FIND_PACKAGE(Qt4 REQUIRED GUI XML SQL) should
define Qt4_FIND_REQUIRED-GUI, Qt4_FIND_REQUIRED-XML and
Qt4_FIND_REQUIRED-SQL

Tags

No tags attached.

Attached Files

cmFindPackageCommand.cxx.diff [^] (701 bytes) 1969-12-31 19:00 [Show Content] [Hide Content]

Index: cmFindPackageCommand.cxx
===================================================================
RCS file: /cvsroot/CMake/CMake/Source/cmFindPackageCommand.cxx,v
retrieving revision 1.15
diff -u -r1.15 cmFindPackageCommand.cxx
--- cmFindPackageCommand.cxx	18 Mar 2005 15:41:40 -0000	1.15
+++ cmFindPackageCommand.cxx	27 Jan 2006 14:07:19 -0000
@@ -75,6 +75,12 @@
       else if(args[i] == "REQUIRED")
         {
         required = true;
+        ++i;
+        while (i < args.size() && args[i] != "QUIET")
+          {
+          std::string req_var = Name + "_FIND_REQUIRED-" + args[i++];
+          m_Makefile->AddDefinition(req_var.c_str(), "1");
+          }
         }
       else
         {

Relationships

Notes
(0003607) 2006-01-27 13:08	I'm assigning this bug to myself. I've implemented the feature and updated the documentation of the FIND_PACKAGE command and in the Modules/readme.txt. Here are the changes: /cvsroot/CMake/CMake/Modules/readme.txt,v <-- readme.txt new revision: 1.7; previous revision: 1.6 /cvsroot/CMake/CMake/Source/cmFindPackageCommand.cxx,v <-- cmFindPackageCommand.cxx new revision: 1.16; previous revision: 1.15 /cvsroot/CMake/CMake/Source/cmFindPackageCommand.h,v <-- cmFindPackageCommand.h new revision: 1.10; previous revision: 1.9 The only difference is that I replaced the "-" before the suffix with "_" to be more consistent with CMake naming conventions. Read the new documentation for details.

(0003608) Brad King (manager) 2006-01-27 13:09	I'm assigning this bug to myself. I've made the changes and updated the documentation. Here are the changes: /cvsroot/CMake/CMake/Modules/readme.txt,v <-- readme.txt new revision: 1.7; previous revision: 1.6 /cvsroot/CMake/CMake/Source/cmFindPackageCommand.cxx,v <-- cmFindPackageCommand.cxx new revision: 1.16; previous revision: 1.15 /cvsroot/CMake/CMake/Source/cmFindPackageCommand.h,v <-- cmFindPackageCommand.h new revision: 1.10; previous revision: 1.9 The only difference is I've replaced the "-" with an "_" before the component-name suffix to be more consistent with CMake naming conventions.

Issue History
Date Modified	Username	Field	Change

Copyright © 2000 - 2018 MantisBT Team