View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0006950

CMake

Modules

public

2008-05-03 17:44

2008-05-03 17:56

Reporter

Boris Dušek

Assigned To

Clinton Stimpson

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

CMake-2-6

Target Version

Fixed in Version

Summary

0006950: FindQt4: QtDBus and Phonon include dir not found on Mac OS X (patch attached)

Description

Hi,

a problem compiling an app on Mac OS X Leopard 10.5.2 using Qt 4.4.0
RC and CMake 2.4.8 (and probably 2.6.0 RC10 as well) as a build system
led me to dig into Modules/FindQt4.cmake and discover something really
suspicious:

for all libraries but QtDBus and phonon, include directories are
searched for in both QT_INCLUDE_DIR/<libname> and
QT_LIBRARY_DIR/<libname>.framework/Headers. But for the two mentioned
libraries, only QT_INCLUDE_DIR/<libname> is searched. This leads to
cmake asking me to manually set QT_QTDBUS_INCLUDE_DIR (in case of
DBus). But the headers would be found if the second variant (the one
with ".framework") would be user. The offending lines are at
Modules/FindQt4.cmake, version 2.6.0 RC10, lines 644 and 683, or the
same file, line 590, for version 2.4.8. Please consider if they are a
bug (I am a beginner with CMake, so I don't feel like making confident
statements about bugs ...).

Now I did not test with CMake 2.6.0, but the same suspicious include
directory logic is still present (and 2.6.10 is the version where
phonon is present, unlike in 2.4.8).

Hope I did not miss something obvious and helped with discovering a bug.

Cheers,
Boris Dušek

Additional Information

Attached is a (IMHO) quick and obvious patch. I did not test with 2.6.0 against which this patch is made, but I did make the same change to a 2.4.8 production installation (only for QtDBus, phonon is not supported at all by 2.4.8), and that removed all the trouble (i.e. the discussed application configuration and compilation worked cleanly (with the classic use like "set(QT_USE_QTDBUS TRUE)").

Tags

No tags attached.

Attached Files

FindQt4.4.0_Mac_Leopard.patch [^] (714 bytes) 2008-05-03 17:44 [Show Content] [Hide Content]

? FindQt4.4.0_Mac_Leopard.path
Index: Modules/FindQt4.cmake
===================================================================
RCS file: /cvsroot/CMake/CMake/Modules/FindQt4.cmake,v
retrieving revision 1.116
diff -u -r1.116 FindQt4.cmake
--- Modules/FindQt4.cmake	10 Apr 2008 14:01:01 -0000	1.116
+++ Modules/FindQt4.cmake	3 May 2008 21:34:02 -0000
@@ -645,6 +645,7 @@
   FIND_PATH(QT_QTDBUS_INCLUDE_DIR QtDBus
     PATHS
     ${QT_INCLUDE_DIR}/QtDBus
+    ${QT_LIBRARY_DIR}/QtDBus.framework/Headers
     NO_DEFAULT_PATH
     )
   
@@ -684,6 +685,7 @@
   FIND_PATH(QT_PHONON_INCLUDE_DIR phonon
     PATHS
     ${QT_INCLUDE_DIR}/phonon
+    ${QT_LIBRARY_DIR}/phonon.framework/Headers
     NO_DEFAULT_PATH
     )

Relationships

Notes
(0011682) Clinton Stimpson (developer) 2008-05-03 17:56	/cvsroot/CMake/CMake/Modules/FindQt4.cmake,v <-- FindQt4.cmake new revision: 1.117; previous revision: 1.116

Issue History
Date Modified	Username	Field	Change
2008-05-03 17:44	Boris Dušek	New Issue
2008-05-03 17:44	Boris Dušek	File Added: FindQt4.4.0_Mac_Leopard.patch
2008-05-03 17:55	Clinton Stimpson	Status	new => assigned
2008-05-03 17:55	Clinton Stimpson	Assigned To	=> Clinton Stimpson
2008-05-03 17:56	Clinton Stimpson	Status	assigned => closed
2008-05-03 17:56	Clinton Stimpson	Note Added: 0011682
2008-05-03 17:56	Clinton Stimpson	Resolution	open => fixed