View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0009567 | CMake | CMake | public | 2009-09-18 14:12 | 2009-09-21 13:32 | ||||
Reporter | dataangel | ||||||||
Assigned To | Brad King | ||||||||
Priority | normal | Severity | minor | Reproducibility | have not tried | ||||
Status | closed | Resolution | no change required | ||||||
Platform | OS | OS Version | |||||||
Product Version | |||||||||
Target Version | Fixed in Version | ||||||||
Summary | 0009567: There should be a DEFAULT_PACKAGE_ROOTS for all find_package .cmake files to use | ||||||||
Description | There are lots of FindFoo.cmake files that contain a FOO_ROOT variable to specify where the root folder to look for lib/include/etc. is. And usually they have a list of paths to check, and across all of the FindXXXX.cmake files they should pretty much be the same: -Look in Program Files on windows -Look in /opt/local on OS X -Look in /usr on *nix These should be provided by a predefined DEFAULT_PACKAGE_ROOTS variable that would contain a list of all the common places for the OS you're building on, so that this stops getting duplicated over and over. I just reported this bug for FindBoost.cmake: http://www.cmake.org/Bug/view.php?id=9566 [^] But I bet it applies to many other packages. | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | |||||||||
Relationships | |
Relationships |
Notes | |
(0017679) Brad King (manager) 2009-09-21 13:32 |
This already exists. It's called "CMAKE_SYSTEM_PREFIX_PATH": http://www.cmake.org/cmake/help/cmake2.6docs.html#variable:CMAKE_SYSTEM_PREFIX_PATH [^] It already takes care of listing 32-bit and 64-bit Program Files directories, etc. Furthermore, all the FIND_* commands already search under it. If a module needs specific package names to be added, it is free to do so. For example, FindBoost could do: set(_boost_INCLUDE_SEARCH_DIRS) foreach(dir ${CMAKE_SYSTEM_PREFIX_PATH}) list(APPEND _boost_INCLUDE_SEARCH_DIRS ${dir}/boost/include ${dir}/boost) endforeach() instead of hard-coding the include search path. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2009-09-18 14:12 | dataangel | New Issue | |
2009-09-21 13:13 | Bill Hoffman | Status | new => assigned |
2009-09-21 13:13 | Bill Hoffman | Assigned To | => Brad King |
2009-09-21 13:32 | Brad King | Note Added: 0017679 | |
2009-09-21 13:32 | Brad King | Status | assigned => closed |
2009-09-21 13:32 | Brad King | Resolution | open => no change required |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |